Skip to content
This repository has been archived by the owner on Jan 29, 2023. It is now read-only.

Fixed warnings from cppcheck (platformio) and -Wall arduino-cli #10

Conversation

Django0
Copy link
Contributor

@Django0 Django0 commented Dec 20, 2020

Based on the issue #8 raised, this is now fixed. Only tested the compilation of
examples/Argument_Simple/Argument_Simple.ino. Do let me know if you have any automated tests that can be run. Also, do let me know if I have overlooked anything with this commit.

@Django0 Django0 closed this Dec 20, 2020
@Django0 Django0 reopened this Dec 20, 2020
@khoih-prog
Copy link
Owner

I'm sorry to let this PR waiting too long time as I've been busy with other things recently.I'm merging it now to master and will update many other related TimerInterrupt libraries (such as TimerInterrupt_Generic ), if applicable.

Thanks for the PR, and especially the explicit constructor conversion to prevent unwanted implicit cast.

I'm looking forward for receiving more of your contributions / PR,

Best Regards,

@khoih-prog khoih-prog merged commit 5fb7e85 into khoih-prog:master Jan 5, 2021
khoih-prog added a commit that referenced this pull request Jan 5, 2021
See PR [Fixed warnings from cppcheck (platformio) and -Wall arduino-cli](#10)
khoih-prog added a commit to khoih-prog/TimerInterrupt_Generic that referenced this pull request Jan 5, 2021
See PR [Fixed warnings from cppcheck (platformio) and -Wall arduino-cli](khoih-prog/TimerInterrupt#10)
khoih-prog added a commit to khoih-prog/TimerInterrupt_Generic that referenced this pull request Jan 5, 2021
See PR [Fixed warnings from cppcheck (platformio) and -Wall arduino-cli](khoih-prog/TimerInterrupt#10)
khoih-prog added a commit to khoih-prog/TimerInterrupt_Generic that referenced this pull request Jan 5, 2021
See PR [Fixed warnings from cppcheck (platformio) and -Wall arduino-cli](khoih-prog/TimerInterrupt#10)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants