Set include dirs to be SYSTEM to prevent user-enabled warnings in header #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the header directories are included normally, which can allow warnings to show up depending on the user's current settings. Changes the public includes to be system so no warnings are triggered. Adds a copy of the includes privately so building the library itself still shows the proper warnings. Also changes glfw's include path to only be added if the variable exists, preventing user's project from including from /include. Signed-off-by: Gabe Gonzalez II <lilggamegenius@gmail.com>
Signed-off-by: Gabe Gonzalez II <lilggamegenius@gmail.com>
Commented out some deprecated flags. Wrap child frame around obsolete macro. Update Child border argument to match new argument. Added new arg with default to Tooltip, allows for passing a bool to enable the tooltip. Defaults to true for compatibility. Signed-off-by: Gabe Gonzalez II <lilggamegenius@gmail.com>
Signed-off-by: Gabe Gonzalez II <lilggamegenius@gmail.com>
|
I kinda forgot I made this so the last 3 commits weren't intended for this PR, although I do think they would make good additions. |
Add recommended defaults for ItemTooltip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the header directories are included normally, which can allow warnings to show up depending on the user's current settings.
This PR changes the public includes to be system so no warnings are triggered and adds a copy of the includes privately so building the library itself still shows the proper warnings.
Also changes glfw's include path to only be added if the variable exists, preventing user's project from including from /include.