Add comments and do not use return in the macros in Key4hepConfig.cmake #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresailer
reviewed
Sep 9, 2024
andresailer
reviewed
Sep 9, 2024
Co-authored-by: Andre Sailer <andre.philippe.sailer@cern.ch>
|
Merging this, I'll push the new version of the file later. |
jmcarcell
added a commit
to key4hep/EDM4hep
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4Clue
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4EDM4hep2LcioConv
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4FWCore
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4geo
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4MarlinWrapper
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4SimDelphes
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4ActsTracking
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4-project-template
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4Reco
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4RecTracker
that referenced
this pull request
Sep 9, 2024
jmcarcell
added a commit
to key4hep/k4GaudiPandora
that referenced
this pull request
Sep 9, 2024
varnes
pushed a commit
to varnes/k4geo
that referenced
this pull request
Sep 17, 2024
BrieucF
added a commit
to key4hep/k4geo
that referenced
this pull request
Sep 18, 2024
…eometry (#379) * Fix bug in cell y position for -z endcap * Add v02 of turbine endcal ecal * Fix up some printouts * Fix printouts * Fix printouts * Fix printouts * Resolve conflicts * update for v2 geometry * Fix printouts * Fix printouts * Update to be compatible with v2 segmentation * Fix printout * comment include of DRC in IDEA o1 v3 * IDEA with DRC dedicated test added * fix IDEA with DRC test * apply other SD action to DRC * update IDEA README * still not working... * replace absolute path by cmake variables in ctest * fix test_IDEA_o1_v03 by removing DRC steering file * IDEA+DRC test is now working * Fix a few compiler warnings (#374) * [FCCeeMDI] Use absolute path to import CAD files * ILD_l5_v11: fix a barrel layer ID (#378) * 2nd SIT barrel layer ID corrected; error stemed from outcommenting previous 2nd layer * removed commented layer to avoid any potential issue in the future * copy TrackerBarrel_o1_v06 * copy CLD_o2_v06 to CLD_o2_v07 * update version * Use new TrackerBarrel * TrackerBarrel_o1_v06 remove using namespace std * move NeighbourSurfacesData population into a function * Move LayerLayout population out of the sensor loop * refactor LayerLayout population into function * TrackerBarrel_o1_v06 add assembly stave * add tracking volume * update README * addExtensionsToHCalAllegro * implemented suggestions from discussion * implement comments and improve code readibility * fix failing test and remove unused phi segmentation * fix endcap bitfields and improve readibility * keep ALLEGRO v03 xml file unchanged * adding version nr also for the barrel xml * update hcal xml files to v02 * add back ECalEndcaps_Turbine * remove unused hcal v01 xml files * update READMEs * add HCalTileBarrel_o1_v02_geo.cpp * CLD_o2_v07: start with new lumical to fix overlaps * CLD_o2_v07: fix overlaps in the LumiCal itself Add a lumical_max_z_prime parameter to get the actual end place of the lumical add 7 micron meter to the envelopes. Fix the location and rotation to use the max_z_prime values * CLD_o2_v07: remove old lumical xml * CLD_o2_v07: InnerTracker: fix envelope overlap between lumical and innertracker * Tests: move CLD test to latest model * CLD_o2_v07: account for lumical positioning with difference between primed and unprimed * Fields: correct type to field_type, changed variable name in DD4hep, type still exists as part of handle * Tests: move one test to something with fieldmaps * Do not link against podio and EDM4hep dictionaries (#386) * Add a Key4hepConfig file * Update Key4hepConfig.cmake with fixes from key4hep/key4hep-dev-utils#7 * Use the Key4hepConfig flag to set the standard, compiler flags (#387) * CLD_o2_v07: LumiCalBackShield: change envelope to an assembly instead of algobal union of intersections... No overlaps detected and the finding points on surface does not complain any more * CLD_o2_v07: LumiCal: replace all envelopes with assemblies at least the lumical specific overlap check with /geometry/test/resolution 300000 is much faster now as well??? * ILD models: apply Tracker_limits to the volume inside of beampipe and MDI (#388) * apply Tracker_limits to the volume inside of beampipe and related MDI elements --------- Co-authored-by: JEANS Daniel Thomelin Dietrich <jeans@cw07.cc.kek.jp> * Remove unused variable, and add information about o1_v02 to the README file * Initialize all variables * Initialize all variables --------- Co-authored-by: Erich Varnes <evarnes@atlng01.physics.arizona.edu> Co-authored-by: Brieuc Francois <brieuc.francois@cern.ch> Co-authored-by: Alvaro Tolosa Delgado <alvaro.tolosa.delgado@cern.ch> Co-authored-by: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com> Co-authored-by: BrieucF <brieucfrancois@hotmail.com> Co-authored-by: Victor Schwan <162138084+Victor-Schwan@users.noreply.github.com> Co-authored-by: Leonhard Reichenbach <leonhard.reichenbach@cern.ch> Co-authored-by: michaela mlynarikova <michaela.mlynarikova@cern.ch> Co-authored-by: Andre Sailer <andre.philippe.sailer@cern.ch> Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> Co-authored-by: Daniel Jeans <daniel.jeans@kek.jp> Co-authored-by: JEANS Daniel Thomelin Dietrich <jeans@cw07.cc.kek.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6.