Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make isFirstEvent work as expected in wrapped processors #92

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Nov 16, 2022

BEGINRELEASENOTES

  • Fix an issue where isFirstEvent always returns false in wrapped processors by calling setFirstEvent after processing the first event.

ENDRELEASENOTES

This was discovered by Jenny and if not fixed, would mean that processors relying on this would need quite a bit of work, see e.g. iLCSoft/MarlinKinfitProcessors#19

@tmadlener
Copy link
Contributor Author

Updated the documentation to state that isFirstEvent does not work in mutli-threaded mode. Should I also add a test that checks that this is working as expected with a simple test processor?

Copy link
Collaborator

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this as well ?

@tmadlener
Copy link
Contributor Author

Yes, unless we want a test for this?

@andresailer
Copy link
Collaborator

Having a test is always better of course. But can add one later, to have this in the tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants