-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to k4run #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvolkl
reviewed
Jan 12, 2023
See my comment on the commit: 59b0c68 . The
logging was added for some ad-hoc debugging, in principle this information is stored in the metadata by the joboptions service. It could be removed, but maybe it is nice to have in the logs. |
andresailer
reviewed
Jan 15, 2023
andresailer
reviewed
Jan 15, 2023
andresailer
reviewed
Jan 18, 2023
Co-authored-by: Andre Sailer <andre.philippe.sailer@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
argparse
only instead of the previous combination of manual parsing andargparse
. I think this is cleaner and if the arguments are wrong it will show the usage automatically (before there was a explicit testing of this)list(set(
that has undetermined ordering, now it will always be sorted in the same order as they were defined in the file (for python >= 3.7, since it is a one liner in that case).logging
for messages as per Use python logger instead of print() in k4Run #50. Right now there is a[k4run]
for the messages that come fromk4run
but this is a placeholder. For example for the Gaudi processes the format looks like[ MESSAGE "VXDEndcapDigitiser"]
and many things can be done like adding the date, the level of the message, etc. I don't have a strong opinion. This is how it looks now:I ran
clicReconstruction.py
on the same file and got similar resultsOther related issues:
I checked and certainly by default the option to attachAlready closed.gdb
is set to false for Gaudi. I could reproduce this issue with the podio reader before Deal with missing files in the readers AIDASoft/podio#355 (by trying to open a non-existent file, now fixed), whereTFile.Open
fails and pullsgdb
. It was very very slow. Interestingly I ran with everything local (withoutcvmfs
) and it took just a couple of seconds to display the backtrace, socvmfs
is at least partly responsible for the slowness.--npcus
with a number different from 0 fails with: