Use podio::Reader and podio::Writer with IOSvc #233
+129
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarcell
force-pushed
the
reader-writer
branch
from
7b1ced1
to
90cbc27
Compare
m-fila
reviewed
Sep 11, 2024
There was a problem hiding this comment.
Is there a reason to dynamically allocate the writer and reader?
- They already are type erased
getWriter()always return a valid object and is always assumed to do so- I think the wrtier's
finishmethod could be called directly instead triggering with pointer reset, no?
Comment on lines
+46
to
+47
| if (m_outputType != "default" && m_outputType != "ROOT" && m_outputType != "RNTuple") { | ||
| error() << "Unknown input type: " << m_outputType << ", expected ROOT, RNTuple or default" << endmsg; |
There was a problem hiding this comment.
podio::Writer allows also SIO. Is this intentional to exclude it?
There was a problem hiding this comment.
The demand for writing EDM4hep files using SIO is quite low. If someone wants it we can add it.
There was a problem hiding this comment.
Could be nice for some testing at some point, but I agree we can easily toggle this once it becomes necessary.
jmcarcell
force-pushed
the
reader-writer
branch
from
90cbc27
to
21095c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
IOTypeparameter given toIOSvcin the steering file.ENDRELEASENOTES