Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CMAKE_{SOURCE,BIN}_DIR -> PROJECT_{SOURCE,BIN}_DIR #213

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Rename CMAKE_{SOURCE,BIN}_DIR -> PROJECT_{SOURCE,BIN}_DIR #213

merged 1 commit into from
Jul 13, 2023

Conversation

jmcarcell
Copy link
Contributor

BEGINRELEASENOTES

  • Rename CMAKE_{SOURCE,BIN}_DIR -> PROJECT_{SOURCE,BIN}_DIR

ENDRELEASENOTES

Makes it possible to build using add_subdirectory. I don't think there are any downsides.

tmadlener
tmadlener approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the proper thing to do. So let's do it.

@tmadlener tmadlener merged commit 75368cb into key4hep:master Jul 13, 2023
7 of 8 checks passed
@jmcarcell
Copy link
Contributor Author

This can also be done in more repos, I'll get to those later

This was referenced Jul 13, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener