-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use provided xpdf_objs library and disable default targets in xpdf #98
Conversation
This code (or a very similar one) works locally with cmake 3.13.4, the restrictions seems to be relaxed with https://gitlab.kitware.com/cmake/cmake/commit/3e774ad78c49cde1f47e1d7285bffef622859d64 that seems to be supported in the release 3.12 |
647e45a
to
5579d9e
Compare
Regarding the Add missing cc @kermitt2 or @lfoppiano for a mode detailed review. |
5579d9e
to
53c0be3
Compare
Rebased on the current master |
- add build/ and install/ to gitignore - upgrade osx_image to the current default (9.4) - the version 8.3 is deprecated - upgrade cmake to version 3.12.* - this allows the usage of the `OBJECT` library inside a `target_link_libraries()` - add PATH to use the updated cmake - patch xpdf mirror - make Qt optional - disable fontconfig
53c0be3
to
6a307e9
Compare
Hi @naufraghi ! First I am very sorry to be so slow to react to your PR... it seems that I have some difficulties to work more than 2-3 days per year on pdfalto :D Thank you very much for the PR and all the improvements it brings. In between I prepared another mirror for xpdf-4.03 containing additional patch for supporting xpdf language packages with relative paths -> https://github.com/kermitt2/xpdf-4.03 From there I will use this mirror first and then include your PR changes manually with this new mirror version. I am also going to check the |
Update to xpdf-4.03 was actually a bit complicated: new usage of fontconfig (if detected), updated form classes, and the Normally everything is good now. I have not yet updated to cmake version 3.12 |
Thanks @kermitt2 , let me know if you'd like a minimal PR extracted from this one |
I'm closing this PR to clean up the list. Thanks for your work in pdfalto! |
This should allow the usage of a plain
xpdf
mirror, without the need of touching theCMakeLists.txt
file.https://cmake.org/cmake/help/latest/command/add_subdirectory.html#command:add_subdirectory
OBJECT
library inside atarget_link_libraries()
codeToGID
argument toXmlAltoOutputDev::getSplashFont()
Closes #99