Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing verbose opt for evaluate_generator #9811

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

ghostplant
Copy link
Contributor

evaluate_generator misses verbose support while evaluate doesn't.

Used for partial enhancement for fit/evaluate/predict API upgrade.

Signed-off-by: CUI Wei ghostplant@qq.com

@fchollet
Copy link
Member

Please add a quick unit test.

Signed-off-by: CUI Wei <ghostplant@qq.com>
@ghostplant
Copy link
Contributor Author

ghostplant commented Apr 1, 2018

Reopening this PR to trigger rebuilding for updated commits, with one more test case added.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fchollet fchollet merged commit 4167831 into keras-team:master Apr 1, 2018
dschwertfeger added a commit to dschwertfeger/keras that referenced this pull request Apr 6, 2018
…ack-embeddings-from-layer-outputs

* upstream/master: (68 commits)
  fit/evaluate_generator supporting native tensors (keras-team#9816)
  keras-team#9642 Add kwarg and documentation for dilation_rate to SeparableConvs (keras-team#9844)
  Document that "same" is inconsistent across backends with strides!=1 (keras-team#9629)
  Improve tests by designating dtype of sample data (keras-team#9834)
  Add documentation for 'subset' and interpolation' arguments (ImageDataGenerator) (keras-team#9817)
  Revert default theme to readthedocs
  Various docs fixes.
  Fix conflict
  Add support for class methods documentation (keras-team#9751)
  Add missing verbose opt for evaluate_generator (keras-team#9811)
  Added `data_format` to flatten layer. (keras-team#9696)
  Allow saving models directly to binary stream (keras-team#9789)
  Fix ctc_batch_cost() error when batch_size = 1 (keras-team#9775)
  Fix keras-team#9802 (keras-team#9803)
  Fix error in ImageDataGenerator documentation (keras-team#9798)
  fix typo (keras-team#9792)
  keras-team#9733: Extend RemoteMonitor to send data as application/json (keras-team#9734)
  Fixed inconsistencies regarding ReduceLROnPlateau (keras-team#9723)
  Fix doc issue.
  General stateful metrics fixes (keras-team#9446)
  ...
Vijayabhaskar96 pushed a commit to Vijayabhaskar96/keras that referenced this pull request May 3, 2018
@alonhazan
Copy link

alonhazan commented May 13, 2018

Keras 2.1.6 changelog indicates "In Model.evaluate_generator, add verbose argument." However, I don't see the API change in that version.
https://github.com/keras-team/keras/blob/2.1.6/keras/models.py

@ghostplant
Copy link
Contributor Author

In 2.1.6, Model.evaluate_generator supports verbose but Sequential is not up to date due to a different wrapper.

This is already solved by Keras > 2.1.6 by the refactor of source codes to make methods of Sequential keep up-to-date with Model.

@ghostplant
Copy link
Contributor Author

ghostplant commented May 13, 2018

This is needed for 2.1.6 but I don't have the access to PR to an old release.

2.1.6...ghostplant:seq_verbose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants