Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteMonitor should send the payload with content-type application/json #9733

Closed
jedrekfulara opened this issue Mar 23, 2018 · 0 comments
Closed

RemoteMonitor should send the payload with content-type application/json #9733

jedrekfulara opened this issue Mar 23, 2018 · 0 comments

Comments

@jedrekfulara
Copy link
Contributor

Currently the RemoteMonitor sends the data as a JSON string encoded within a form. This is very inconvenient for modern clients that have great support for JSON payloads, but they usually expect the content type to be application/json.

To keep the backward compatiblitity, I suggest extending the RemoteMonitor constructor's signature by adding encode_as_json=False parameter. When set to True it would send out the request with the appropriate content type.
jedrekfulara added a commit to sparkbitpl/keras that referenced this issue Mar 23, 2018
@jedrekfulara
keras-team#9733: Extend RemoteMonitor to send data as application/json
4bdff54
Dref360 pushed a commit that referenced this issue Mar 27, 2018
@jedrekfulara
#9733: Extend RemoteMonitor to send data as application/json (#9734)
f7afc73 
* #9733: Extend RemoteMonitor to send data as application/json
dschwertfeger added a commit to dschwertfeger/keras that referenced this issue Apr 6, 2018
@dschwertfeger
Merge remote-tracking branch 'upstream/master' into tensorboard-callb…
a250176 
…ack-embeddings-from-layer-outputs

* upstream/master: (68 commits)
  fit/evaluate_generator supporting native tensors (keras-team#9816)
  keras-team#9642 Add kwarg and documentation for dilation_rate to SeparableConvs (keras-team#9844)
  Document that "same" is inconsistent across backends with strides!=1 (keras-team#9629)
  Improve tests by designating dtype of sample data (keras-team#9834)
  Add documentation for 'subset' and interpolation' arguments (ImageDataGenerator) (keras-team#9817)
  Revert default theme to readthedocs
  Various docs fixes.
  Fix conflict
  Add support for class methods documentation (keras-team#9751)
  Add missing verbose opt for evaluate_generator (keras-team#9811)
  Added `data_format` to flatten layer. (keras-team#9696)
  Allow saving models directly to binary stream (keras-team#9789)
  Fix ctc_batch_cost() error when batch_size = 1 (keras-team#9775)
  Fix keras-team#9802 (keras-team#9803)
  Fix error in ImageDataGenerator documentation (keras-team#9798)
  fix typo (keras-team#9792)
  keras-team#9733: Extend RemoteMonitor to send data as application/json (keras-team#9734)
  Fixed inconsistencies regarding ReduceLROnPlateau (keras-team#9723)
  Fix doc issue.
  General stateful metrics fixes (keras-team#9446)
  ...
Vijayabhaskar96 pushed a commit to Vijayabhaskar96/keras that referenced this issue May 3, 2018
@jedrekfulara @Vijayabhaskar96
keras-team#9733: Extend RemoteMonitor to send data as application/json (
da18ae7 
keras-team#9734)

* keras-team#9733: Extend RemoteMonitor to send data as application/json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fchollet @jedrekfulara