Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning for mismatched inputs structure in Functional #20170

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

james77777778
Copy link
Contributor

There are several issues related to mismatched inputs structure:

As a result, it would be beneficial to add a warning for users.
Ultimately, we might want to raise an error when a mismatch occurs. Otherwise, it could lead to subtle issues if the inputs have the same shape and dtype, as the computation could be incorrect even though the code runs.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.34%. Comparing base (3cc4d44) to head (dddfbfe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20170   +/-   ##
=======================================
  Coverage   79.34%   79.34%           
=======================================
  Files         501      501           
  Lines       47319    47325    +6     
  Branches     8692     8694    +2     
=======================================
+ Hits        37544    37550    +6     
  Misses       8017     8017           
  Partials     1758     1758           
Flag Coverage Δ
keras 79.19% <100.00%> (+<0.01%) ⬆️
keras-jax 62.47% <100.00%> (+<0.01%) ⬆️
keras-numpy 57.65% <100.00%> (+0.07%) ⬆️
keras-tensorflow 63.85% <100.00%> (+<0.01%) ⬆️
keras-torch 62.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement -- LGTM

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 27, 2024
@fchollet fchollet merged commit cb233fa into keras-team:master Aug 27, 2024
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Aug 27, 2024
@james77777778 james77777778 deleted the add-warning branch August 28, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants