Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svd with compute_uv=False #20122

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

james77777778
Copy link
Contributor

Fix #20094

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.32%. Comparing base (b45be33) to head (83ce6f4).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20122      +/-   ##
==========================================
+ Coverage   79.29%   79.32%   +0.02%     
==========================================
  Files         501      501              
  Lines       46984    46986       +2     
  Branches     8659     8662       +3     
==========================================
+ Hits        37258    37271      +13     
+ Misses       7976     7968       -8     
+ Partials     1750     1747       -3     
Flag Coverage Δ
keras 79.17% <100.00%> (+0.02%) ⬆️
keras-jax 62.49% <0.00%> (+0.01%) ⬆️
keras-numpy 57.55% <0.00%> (+0.05%) ⬆️
keras-tensorflow 63.85% <66.66%> (+0.02%) ⬆️
keras-torch 62.53% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 14, 2024
@fchollet fchollet merged commit 6fd4873 into keras-team:master Aug 14, 2024
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Aug 14, 2024
@james77777778 james77777778 deleted the fix-svd branch August 15, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVD operation failed when compute_uv=False (TF backend)
4 participants