Fix ConvNeXt classifier activation bug #17544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frightera
changed the title
google-ml-butler
bot
added
the
keras-team-review-pending
qlzh727
requested changes
Feb 9, 2023
|
Should be fine now. |
qlzh727
requested changes
Feb 10, 2023
Frightera
changed the title
Frightera
changed the title
This reverts commit 00d4889.
grasskin
removed
the
keras-team-review-pending
Frightera
changed the title
|
@qlzh727 It looks like this is ready to pull, if there is any other thing please let me know. Thanks! |
qlzh727
approved these changes
Feb 13, 2023
google-ml-butler
bot
added
kokoro:force-run
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
Imported from GitHub PR #17544 Fixes the issue #17386. Please find the bug, fix, and test [gist here](https://colab.research.google.com/gist/Frightera/93a784fc0e03a19f5804e7e14bfbecba/-17386.ipynb). Copybara import of the project: -- eedabb6 by Kaan <46622558+Frightera@users.noreply.github.com>: Pass classifier_activation arg to "Head" -- e226091 by Kaan <46622558+Frightera@users.noreply.github.com>: Add classifier_activation to the docstring -- 3856fed by Kaan <46622558+Frightera@users.noreply.github.com>: Add classifier_activation unit test -- c3dfc34 by Kaan <46622558+Frightera@users.noreply.github.com>: Move classifier_activation validation before head creation -- 71eaa69 by Kaan <46622558+Frightera@users.noreply.github.com>: Update test_application_classifier_activation -- ebd6940 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>: Reformatting using format.sh -- bce4ac9 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>: Fix test_application_classifier_activation test -- 00d4889 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>: Fix Head params to accept classifier_activation -- 2c22d37 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>: Revert "Fix Head params to accept classifier_activation" This reverts commit 00d4889. -- 3abd441 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>: Exclude RegNet in test_application_classifier_activation Merging this change closes #17544 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17544 from Frightera:frightera_fix_17386 3abd441 PiperOrigin-RevId: 509550999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue keras-team/tf-keras#319.
Please find the bug, fix, and test gist here.