Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Add Example] Create reproducibility_recipes.py #1353

Merged
merged 6 commits into from
May 27, 2023
Merged

[Add Example] Create reproducibility_recipes.py #1353

merged 6 commits into from
May 27, 2023

Conversation

Frightera
Copy link
Contributor

This quick Keras recipe demonstrates how Keras initializers behave, and shows what's needed to achieve identical results in subsequential runs in model training process.

#1332

LukeWood
LukeWood reviewed May 9, 2023
View reviewed changes
Copy link
Contributor

@LukeWood LukeWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a useful guide - I think we could greatly simplify this code and make it very concise by removing a lot of the module inspection code and some of the more complex logic loops!

@Frightera
Copy link
Contributor Author

@LukeWood Thanks for the review, I simplified those parts, can you take a look at when you have time?

@Frightera Frightera requested a review from LukeWood May 9, 2023 10:30
fchollet
fchollet reviewed May 17, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Looking good! 👍

examples/keras_recipes/reproducibility_recipes.py Outdated Show resolved Hide resolved
examples/keras_recipes/reproducibility_recipes.py Show resolved Hide resolved
examples/keras_recipes/reproducibility_recipes.py Show resolved Hide resolved
@Frightera
Copy link
Contributor Author

Hi @fchollet, thank you for your comments. Now I provided more explanation for the shuffle process.

@Frightera Frightera requested a review from fchollet May 17, 2023 21:06
fchollet
fchollet approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Everything looks good to me. You can add the generated files.

@Frightera
Copy link
Contributor Author

@fchollet Done! I think this is ready to be merged 😄 Here's a snippet:

image

fchollet
fchollet approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the great contribution! 👍

@fchollet fchollet merged commit 2cb8821 into keras-team:master May 27, 2023
3 checks passed
@Frightera Frightera deleted the keras_reprod_recipes branch May 28, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

@LukeWood LukeWood Awaiting requested review from LukeWood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frightera @fchollet @LukeWood