Improve keras 3 detection #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
divyashreepathihalli
force-pushed
the
keras_3_detection
branch
4 times, most recently
from
97cf251
to
53a209a
Compare
divyashreepathihalli
force-pushed
the
keras_3_detection
branch
from
1b78749
to
6203623
Compare
divyashreepathihalli
force-pushed
the
keras_3_detection
branch
from
42d6798
to
4883a17
Compare
|
/gcbrun |
|
/gcbrun |
mattdangerw
requested changes
Nov 8, 2023
|
/gcbrun |
mattdangerw
requested changes
Nov 8, 2023
| @@ -25,5 +28,5 @@ | |||
| from keras_core.src.utils.image_utils import ( # noqa: F403, F401 | |||
| smart_resize, | |||
| ) | |||
| else: | |||
| if not multi_backend(): | |||
| from keras_cv.backend.tf_ops import * # noqa: F403, F401 | |||
There was a problem hiding this comment.
Why are we importing tf_ops twice? Once here and once from the toplevel __init__.py? Do we need both?
There was a problem hiding this comment.
I think this was added to have tf_ops to be available through keras_cv.backend.ops.* instead of keras_cv.backend.tf_ops.*
|
/gcbrun |
mattdangerw
approved these changes
Nov 9, 2023
yuvraj-wale
pushed a commit
to yuvraj-wale/keras-cv
that referenced
this pull request
Feb 8, 2024
* improve keras 3 detection * update __init__ * update config * update config to update multibackend flag * updated spelling error * updatconfig * update tf_ops * update tf -ops * update tf ops * undo last commit * update tf_ops.py * reformat * update init() * update minor error in tf ops * remove check for keras 3 * revert changes to tf_ops * disable layers using internal base random layer * update syntax error * update imports in keras version check layer * update init method in keras version check * add seed argument * rasie error in class itself * update constructor * update to import directly from layers * update import in base image augmenattion layer * change import sin tf_ops * update tf ops import * change init * update tf_ops * update backend functions * keras.src * update namespace * update namescope correctly * code reformat * reformat and add backend functions * modified ops import * reformat * update ops * update backend * update ops * code reformatted * update import * update imports in ops * update error message * review changes added * update keras imports * update imports * update imports * update import in random.py * add issues link * code reformat * code reformat * review comments addressed * code reformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To-dos added for after this PR is merged
convert these layers to keras 3. These layers are disabled for keras 3 for now.
dropblock_2d: #2135
BaseAugmentationLayer3D: #2136
fix legacy keras.engine import in predict_utils.py
#2134
These changes have been tested here
https://colab.sandbox.google.com/drive/1pGSji4tto6Fu88LXR0z4p7ExJZWNajGK#scrollTo=9s7Q0WbIa6vB