Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BASNet model #2006

Closed
martin-gorner opened this issue Aug 2, 2023 · 8 comments · Fixed by #2271
Closed

BASNet model #2006

martin-gorner opened this issue Aug 2, 2023 · 8 comments · Fixed by #2271
Assignees
@hamidriasat @tirthasheshpatel
Labels
stat:contributions welcome

Comments

@martin-gorner
Copy link

martin-gorner commented Aug 2, 2023 •
edited
Loading

Add the BASNet segmentation model to KerasCV.

A keras.io BASNet example already exists, based on this BASNet implementation, both from Hamid Ali.

The API should follow that of the existing DeepLabV3 model.
@martin-gorner
Copy link
Author

@hamidriasat, would you like to contribute your BASNet implementation?

@IMvision12
Copy link
Contributor

I can add this model @martin-gorner !

@hamidriasat
Copy link
Contributor

@martin-gorner Yes, I would be delighted to contribute my BASNet implementation to KerasCV.

@jbischof
Copy link
Contributor

jbischof commented Aug 2, 2023

Thanks @hamidriasat! Thanks as well for your offer @IMvision12 but since Hamid wrote the example we'll give him first pass.

@divyashreepathihalli
Copy link
Collaborator

@hamidriasat are you working on this?

@hamidriasat
Copy link
Contributor

@divyashreepathihalli
Hi, sorry for the delay I was busy with other things.
But I am working on it, here you can check the initial progress with the model added.

I have also successfully added test cases for BASNet but will push the code once It's cleaned.
My plan is to soon submit a pull request with the model and test cases, then paper weights will be added later, kindly let me know, will this work?

@tirthasheshpatel
Copy link
Contributor

Glad to see so much progress! It looks good and should work. Feel free to open a draft PR if you want.

@hamidriasat hamidriasat mentioned this issue Jan 3, 2024
Merged
5 tasks
@divyashreepathihalli
Copy link
Collaborator

Thank you for submitting the PR @hamidriasat! Great job!!

divyashreepathihalli pushed a commit that referenced this issue Jan 17, 2024
@hamidriasat
Add BASNet Segmentation Model (#2006) (#2271)
5796b76 
* BASNet model initial code structure

* adding test and initial preset details

* adding comments

* cleaning and formatting code

* keras 3 support added

* disabling preset test for BASNet
sampathweb pushed a commit that referenced this issue Jan 31, 2024
@hamidriasat @sampathweb
Add BASNet Segmentation Model (#2006) (#2271)
b362546 
* BASNet model initial code structure

* adding test and initial preset details

* adding comments

* cleaning and formatting code

* keras 3 support added

* disabling preset test for BASNet
sampathweb added a commit that referenced this issue Jan 31, 2024
@sampathweb @mattdangerw
@grasskin @sachinprasadhs @haifeng-jin @hamidriasat @tirthasheshpatel
Create patch release r0.8.2 (#2326)
7eee38a 
* Move keras-cv markdown files to toplevel (#2291)

Keras, KerasNLP and KerasTuner all store things liek the CONTRIBUTING.md
in the toplevel of the repo. We should do the same here.

* Add `version()` API to unify with Keras and KerasNLP (#2199)

* Unify `version` API with keras and keras_nlp

* Formatting

* Update to keep `version` parity with KerasNLP, support nightly version string

* Update version_utils.py

* Update version_utils.py

* Update random_crop_and_zoom.py (#2294)

* Update random_crop_and_zoom.py

* Update description

* rename file

* bug fix (#2303)

* Add BASNet Segmentation Model (#2006) (#2271)

* BASNet model initial code structure

* adding test and initial preset details

* adding comments

* cleaning and formatting code

* keras 3 support added

* disabling preset test for BASNet

* Fix image.shape type (#2305)

Fixed image.shape issue for tensorflow backend

* Create workflow for auto assignment of issues and for stale issues (#2313)

* Create auto-assignment.yaml

* Create auto-assignment.js

* Create stale-issue-pr.yaml

* Rename auto-assignment.yaml to auto-assignment.yml

* Rename stale-issue-pr.yaml to stale-issue-pr.yml

* Fix format and Update Vectorized Base (#2323)

* Fix CI Test for Basnet OOM and PyCoCo Test Failure for JAX (#2322)

* Reduce memory consumption for BasNet tests (#2325)

---------

Co-authored-by: Matt Watson <1389937+mattdangerw@users.noreply.github.com>
Co-authored-by: Gabriel Rasskin <43894452+grasskin@users.noreply.github.com>
Co-authored-by: Sachin Prasad <sachinprasad@google.com>
Co-authored-by: Haifeng Jin <5476582+haifeng-jin@users.noreply.github.com>
Co-authored-by: Hamid Ali <hamidriasat@gmail.com>
Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com>
yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this issue Feb 8, 2024
@hamidriasat @yuvraj-wale
Add BASNet Segmentation Model (keras-team#2006) (keras-team#2271)
4e5e76a 
* BASNet model initial code structure

* adding test and initial preset details

* adding comments

* cleaning and formatting code

* keras 3 support added

* disabling preset test for BASNet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamidriasat hamidriasat

@tirthasheshpatel tirthasheshpatel

Labels
stat:contributions welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BASNet Segmentation Model (#2006) hamidriasat/keras-cv
6 participants
@martin-gorner @jbischof @hamidriasat @tirthasheshpatel @divyashreepathihalli @IMvision12