-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow lifecycle events longer than one hour #69
Conversation
This adds --max-time-to-process to allow wait states longer than the one hour default. AWS allows up to 48 hour wait states (or 100 times the heartbeat timeouts, whichever is shorter). https://docs.aws.amazon.com/autoscaling/ec2/userguide/lifecycle-hooks.html#lifecycle-hook-wait-state Signed-off-by: mrak and cale <emrak@paypal.com>
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 69.82% 69.74% -0.08%
==========================================
Files 12 12
Lines 898 899 +1
==========================================
Hits 627 627
- Misses 211 212 +1
Partials 60 60
Continue to review full report at Codecov.
|
Thanks @mrak this looks good. |
We set the heartbeat timeout to The expectation was that the 100*heartbeat limit would be hit before the max time to process, which we verified to be the case. At that point the ASG moved on with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This adds
--max-time-to-process
to allow wait states longer than the one hour default. AWS allows up to 48 hour wait states (or 100 times the heartbeat timeout, whichever is shorter). This was previously a hardcoded value of3600
seconds, which remains the default if this flag is not specified.https://docs.aws.amazon.com/autoscaling/ec2/userguide/lifecycle-hooks.html#lifecycle-hook-wait-state