Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kubectl binary to v1.18.14 #68

Merged

Conversation

vgunapati
Copy link
Contributor

No description provided.

@vgunapati vgunapati requested a review from a team as a code owner January 19, 2021 22:37
@CLAassistant
Copy link

CLAassistant commented Jan 19, 2021

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Venkata Gunapati <gvsukumar@gmail.com>
@eytan-avisror
Copy link
Collaborator

I think you need to sign off DCO @vgunapati
Also, should we also update client-go to same version? or is there a specific reason we need to update kubectl exclusively? if there is a bug with 1.16.x kubectl we can merge this now and update client-go later

@vgunapati vgunapati force-pushed the feature/upgrade-kubectl-1.18.14 branch from 97e0f55 to debb431 Compare January 19, 2021 22:44
@vgunapati
Copy link
Contributor Author

vgunapati commented Jan 19, 2021

@eytan-avisror we don't have any bug with 1.16, based on this doc kubectl is supported within one minor version (older or newer) of kube-apiserver

we should update client-go as well but will need more testing, as the current client-go is based on git hash

k8s.io/client-go v0.0.0-20190620085101-78d2af792bab

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #68 (debb431) into master (06857be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   69.82%   69.82%           
=======================================
  Files          12       12           
  Lines         898      898           
=======================================
  Hits          627      627           
  Misses        211      211           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06857be...debb431. Read the comment docs.

@eytan-avisror eytan-avisror merged commit d9d1df9 into keikoproj:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants