Handle in-progress events without deadlocking #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When in-progress messages are sent to the eventStream channel, lifecycle-manager deadlocks, since there are no eventStream receivers running in a separate goroutine. Instead of sending the in-progress messages to the eventStream channel, we can process them immediately as we process SQS-driven events, avoiding the deadlock. Resolves keikoproj#62
|
This could be a bit more DRY, let me know if you'd like me to make changes. |
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 72.37% 72.08% -0.30%
==========================================
Files 12 12
Lines 992 996 +4
==========================================
Hits 718 718
- Misses 212 216 +4
Partials 62 62
Continue to review full report at Codecov.
|
|
Thanks @JacobHenner this is great, I think the goal of the refactor was to reduce number of goroutines (hence getting rid of newWorker method) and optimize performance under high load of terminations - but you are absolutely right about the deadlock. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in-progress messages are sent to the eventStream channel,
lifecycle-manager deadlocks, since there are no eventStream receivers
running in a separate goroutine. Instead of sending the in-progress
messages to the eventStream channel, we can process them immediately as
we process SQS-driven events, avoiding the deadlock.
Resolves #62