Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kubectl binary to v1.16.15 #60

Merged

Conversation

JacobHenner
Copy link
Contributor

Using kubectl 1.12 with clusters >= 1.16 results in DaemonSets not being
handled properly during drains, due to the removal of several deprecated
API versions for DaemonSets. kubectl 1.16 uses the stable API for
DaemonSets, which fixes this issue.

Resolves #59

Using kubectl 1.12 with clusters >= 1.16 results in DaemonSets not being
handled properly during drains, due to the removal of several deprecated
API versions for DaemonSets. kubectl 1.16 uses the stable API for
DaemonSets, which fixes this issue.

Resolves keikoproj#59
@JacobHenner JacobHenner requested a review from a team as a code owner September 9, 2020 20:46
@CLAassistant
Copy link

CLAassistant commented Sep 9, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eytan-avisror eytan-avisror merged commit 0a3c2ae into keikoproj:master Sep 9, 2020
@eytan-avisror eytan-avisror mentioned this pull request Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DaemonSets not handled properly in clusters >=1.16
3 participants