-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for refreshing expired AWS token #57
Add option for refreshing expired AWS token #57
Conversation
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 72.37% 72.37%
=======================================
Files 12 12
Lines 992 992
=======================================
Hits 718 718
Misses 212 212
Partials 62 62 Continue to review full report at Codecov.
|
Thanks for the contribution @andrejvanderzee 👍 |
327520e
to
82b3a1b
Compare
82b3a1b
to
5143caf
Compare
@eytan-avisror Yes you are right I guess I overlooked. Fixed the caching statements. Can you please have another look? |
Thanks @andrejvanderzee it looks good. |
Yes I had it running and looks good. Here the debug output of a recovering connection from an expired token 403 response:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
@eytan-avisror Thanks for your prompt replies and merging my PR! |
BTW, would it be possible to tag 0.4.1? |
@andrejvanderzee NP, thanks again for contributing. |
We are running in Kubernetes context with ephemeral AWS credentials which are refreshed every X hours. This PR adds an option that re-reads credentials from AWS shared credential file and retries the request.