Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Kind, firsttimestamp and count to v1.Event #56

Merged
merged 2 commits into from
May 27, 2020

Conversation

vigith
Copy link
Contributor

@vigith vigith commented May 27, 2020

  • log error if localmode is pointing to erroneous config file
  • add Kind to v1.Event
  • set firsttimestamp and count in v1.Event

log

INFO[0084] deregistrator> no active targets for deregistration 
INFO[0085] event e285c95b-42fb-f2b6-fe20-024df0f6d7e8 completed processing 
INFO[0086] i-003caf2e52c34fb3e> setting lifecycle event as completed with result: CONTINUE 
INFO[0086] event e285c95b-42fb-f2b6-fe20-024df0f6d7e8 for instance i-003caf2e52c34fb3e completed after 9.659177478s 

get events

3m24s       Normal   LifecycleHookReceived                                                                                        lifecyclemanager                                    {"asgName":"mpa-eks-play2-instance-manager-nodes","details":"lifecycle hook for event e285c95b-42fb-f2b6-fe20-024df0f6d7e8 was received, instance i-003caf2e52c34fb3e will begin processing","ec2InstanceId":"i-003caf2e52c34fb3e","eventID":"e285c95b-42fb-f2b6-fe20-024df0f6d7e8"}
3m19s       Normal   NodeDrainSucceeded                                                                                           lifecyclemanager                                    {"asgName":"mpa-eks-play2-instance-manager-nodes","details":"node ip-10-233-245-169.us-west-2.compute.internal has been drained successfully as a response to a termination event","ec2InstanceId":"i-003caf2e52c34fb3e","eventID":"e285c95b-42fb-f2b6-fe20-024df0f6d7e8"}
3m13s       Normal   LifecycleHookProcessed                                                                                       lifecyclemanager                                    {"asgName":"mpa-eks-play2-instance-manager-nodes","details":"lifecycle hook for event e285c95b-42fb-f2b6-fe20-024df0f6d7e8 has completed processing, instance i-003caf2e52c34fb3e gracefully terminated after 9.659177478s","ec2InstanceId":"i-003caf2e52c34fb3e","eventID":"e285c95b-42fb-f2b6-fe20-024df0f6d7e8"}

@vigith vigith requested a review from a team as a code owner May 27, 2020 15:55
Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #56 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   72.23%   72.37%   +0.13%     
==========================================
  Files          12       12              
  Lines         987      992       +5     
==========================================
+ Hits          713      718       +5     
  Misses        212      212              
  Partials       62       62              
Impacted Files Coverage Δ
pkg/service/events.go 84.61% <100.00%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d66fcd1...ba80109. Read the comment docs.

@eytan-avisror eytan-avisror merged commit 97429fa into keikoproj:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants