Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor message validation #55

Merged

Conversation

eytan-avisror
Copy link
Collaborator

Adds to #54

This PR refactors message validation so that it's more accurate and no longer spins up goroutines before the message is validated.
It also removes some redundant functions

@eytan-avisror eytan-avisror requested a review from a team as a code owner April 27, 2020 18:12
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #55 into master will decrease coverage by 0.55%.
The diff coverage is 64.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   72.78%   72.23%   -0.56%     
==========================================
  Files          12       12              
  Lines        1018      987      -31     
==========================================
- Hits          741      713      -28     
  Misses        212      212              
+ Partials       65       62       -3     
Impacted Files Coverage Δ
pkg/service/lifecycle.go 100.00% <ø> (+38.46%) ⬆️
pkg/service/server.go 61.35% <49.09%> (-0.99%) ⬇️
pkg/service/manager.go 71.17% <78.12%> (-10.65%) ⬇️
pkg/service/elb.go 100.00% <100.00%> (ø)
pkg/service/elbv2.go 100.00% <100.00%> (ø)
pkg/service/events.go 82.35% <100.00%> (+3.78%) ⬆️
pkg/service/sqs.go 72.72% <100.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc9d3e...8fff5c1. Read the comment docs.

@eytan-avisror eytan-avisror merged commit d66fcd1 into keikoproj:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants