only do alb deregister for nodes with specific label #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 66.52% 66.58% +0.05%
==========================================
Files 15 15
Lines 1168 1170 +2
==========================================
+ Hits 777 779 +2
Misses 319 319
Partials 72 72 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zihan Jiang <jiangzhsysu@gmail.com>
ZihanJiang96
force-pushed
the
alb-deregister-by-node-label
branch
from
912ad39
to
298eeec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip alb deregistration if the node doesn't have label
lifecycle-manager.keikoproj.io/enable-alb-deregisterset to"true"