Allow drain retries even with timeout failures #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update go version and add cross-compilation Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com> * remove build from unit-test Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
* Ignore local IDE files Signed-off-by: kevdowney <kevdowney@gmail.com> * Cleanup Makefile Signed-off-by: kevdowney <kevdowney@gmail.com> * Update GH Actions to use ubuntu-latest Signed-off-by: kevdowney <kevdowney@gmail.com> * Add `dependabot.yml` Signed-off-by: kevdowney <kevdowney@gmail.com> --------- Signed-off-by: kevdowney <kevdowney@gmail.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Bumps [docker/login-action](https://github.com/docker/login-action) from 1 to 2. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v1...v2) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
* Ignore major,minor versions of k8s.io libs * Use base version (v3) for actions/checkout --------- Signed-off-by: kevdowney <kevdowney@gmail.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: kevdowney <kevdowney@gmail.com> Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 71.02% 70.74% -0.28%
==========================================
Files 12 12
Lines 1239 1234 -5
==========================================
- Hits 880 873 -7
- Misses 296 298 +2
Partials 63 63
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
figo
approved these changes
May 4, 2023
Merged
2rs2ts
added a commit
to 2rs2ts/lifecycle-manager
that referenced
this pull request
Jan 8, 2024
It seems like keikoproj#104 added this option, but since that wasn't yet released, it wasn't added to the README. Now it's part of a release, so, it should be fine to add to the README.
2rs2ts
added a commit
to 2rs2ts/lifecycle-manager
that referenced
this pull request
Jan 8, 2024
It seems like keikoproj#104 added this option, but since that wasn't yet released, it wasn't added to the README. Now it's part of a release, so, it should be fine to add to the README. Signed-off-by: 2rs2ts <2rs2ts@users.noreply.github.com>
ZihanJiang96
pushed a commit
that referenced
this pull request
Feb 3, 2024
It seems like #104 added this option, but since that wasn't yet released, it wasn't added to the README. Now it's part of a release, so, it should be fine to add to the README. Signed-off-by: 2rs2ts <2rs2ts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90