-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: Buy Token #249
base: main
Are you sure you want to change the base?
Frontend: Buy Token #249
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@KeneePatel is attempting to deploy a commit to the keep-starknet-strange Team on Vercel. A member of the Team first needs to authorize it. |
closes issue: #226 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR ! I'll just fix some things
Hey @0xChqrles, Please let me know if any more change is required, I will be happy to do the changes and push it to the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Thanks for the work and sorry for so late response! I've just requested one small change, after that we can merge, LGTM
const DEFAULT_SLIPPAGE = 0.5 | ||
const DEFAULT_AMOUNT = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These can be moved to the constants
Updated the Token page to have options to buy token.
the UI looks at the moment looks like this:
![image](https://private-user-images.githubusercontent.com/59523692/327970188-8219f7dc-8f07-42b2-b8c7-07b46a6718e0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyNjQ4MDcsIm5iZiI6MTcyNDI2NDUwNywicGF0aCI6Ii81OTUyMzY5Mi8zMjc5NzAxODgtODIxOWY3ZGMtOGYwNy00MmIyLWI4YzctMDdiNDZhNjcxOGUwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIxVDE4MjE0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM5YTQyYzg0ZmQ4ZDAzMTE5MzE4ZTZmMDllMGEwOGU4MjNkNWVkOTFkYmE4MjAxMWIwOTM1MjE5ODhkNTRiNTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.TYR1lsVoTVTPAs0Vapu7qzjupY1rbBjBkLRySPeWJpo)