Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Buy Token #249

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KeneePatel
Copy link

Updated the Token page to have options to buy token.

the UI looks at the moment looks like this:
image

Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unruggable-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 10:42am

Copy link

vercel bot commented May 4, 2024

@KeneePatel is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

@KeneePatel
Copy link
Author

closes issue: #226

Copy link
Contributor

@0xChqrles 0xChqrles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR ! I'll just fix some things

packages/core/tsup.config.bundled_chopd27o9.mjs Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@KeneePatel
Copy link
Author

Hey @0xChqrles,

Please let me know if any more change is required, I will be happy to do the changes and push it to the branch.

Copy link
Collaborator

@ugur-eren ugur-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for the work and sorry for so late response! I've just requested one small change, after that we can merge, LGTM

Comment on lines +14 to +15
const DEFAULT_SLIPPAGE = 0.5
const DEFAULT_AMOUNT = 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be moved to the constants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants