-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bandersnatch curve #128
base: main
Are you sure you want to change the base?
feat: add bandersnatch curve #128
Conversation
@feltroidprime Thanks for the review, I have addressed the comments! It should be fine now. Strange thing is that msm for 1,2,3 points are fine with bandersantch, but 256 points is failing for some reason |
Yes it is expected, circuits have been compiled for up to 3 points for the LHS of the equation to verify
For the RHS, it supports any number of points as it calls the same circuit in a loop : garaga/src/fustat/ec_ops.cairo Line 233 in dac4311
garaga/hydra/precompiled_circuits/ec.py Line 243 in dac4311
garaga/hydra/precompiled_circuits/all_circuits.py Lines 352 to 357 in dac4311
For now, please just comment the n=256 line in the test so I can merge this, and we can add it later or make a specific n=256 circuit for it. |
@feltroidprime Thanks for the explanation, just commented out line for testing 256 points |
hi @feltroidprime can we merge this? I want to pull some benchmarks regarding proof costs/number of steps. |
Pull Request type
Adding bandersnatch parameters https://eprint.iacr.org/2021/1152.pdf
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information