Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transcoding related utility functions to Kedro viz #1928

Merged
merged 2 commits into from
May 29, 2024

Conversation

ankatiyar
Copy link
Contributor

Description

To address deprecation warnings because we moved around TRANSCODING_SEPARATOR a few times :P

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankatiyar , this looks amazing!!!.

Some point in the future - we need to revise utils.py files as we have about 4 now. but this makes sense especially coz it's used in multiple places in kedro-viz

@ankatiyar ankatiyar merged commit cead746 into main May 29, 2024
33 checks passed
@ankatiyar ankatiyar deleted the transcoding-take2 branch May 29, 2024 11:43
@rashidakanchwala rashidakanchwala mentioned this pull request May 29, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants