Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve viz url #1907

Merged
merged 77 commits into from
Jun 6, 2024
Merged

Retrieve viz url #1907

merged 77 commits into from
Jun 6, 2024

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented May 15, 2024

Description

Fixes #1851
Design is here
retrieve-url

Development notes

  • we store store the fields including hosting platform, bucket name and endpoint URL in localStorage once the user publishes it. The format is as follow
{
   aws: {
       bucket_name: ...,
       platform: 'aws',
       endpoint: '....',
   },
   gcp: {....},
   azure: {....}
}
  • Render the published content view will depends on whether there's only 1 hosting platform stored in localStorage or more than 1
  • Current logic is summarised as the chart below
Screenshot 2024-05-21 at 16 48 53

QA notes

You can test the UI using Gitpod. I've implemented the logic prior to the check that validates whether the submitted platform is valid or not. As a result, you can use any fabricated names and URLs, the system will display an error message.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Huongg added 30 commits May 7, 2024 14:16
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
…iz-url

Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
@ravi-kumar-pilla
Copy link
Contributor

Hi @Huongg , Apologies for the delay in reviewing the PR. Most of the code looks good. I had a first pass and left few comments and questions. Please have a look. Thank you

Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
src/config.js Outdated Show resolved Hide resolved
Co-authored-by: Ravi Kumar Pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
@ravi-kumar-pilla
Copy link
Contributor

Hi @Huongg , Thanks for addressing all the comments. There are some minor observations and I would like to know what the team thinks @stephkaiser @jitu5 -

  1. When closing the modal of published view - It changes the form before closing the modal (minor thing but seems like something is changing on the screen)
  2. When closing the modal of main content from published view - It changes the modal to publish view before closing (minor thing but seems like something is changing on the screen)
  3. When I click on republish, the form data gets filled based on the selected provider, but if I change the dropdown source, even if the provider is in localStorage, the form is not populated.

Let me know if you need more info. Thank you

minor_close_issue

@Huongg
Copy link
Contributor Author

Huongg commented Jun 6, 2024

Hi @Huongg , Thanks for addressing all the comments. There are some minor observations and I would like to know what the team thinks @stephkaiser @jitu5 -

  1. When closing the modal of published view - It changes the form before closing the modal (minor thing but seems like something is changing on the screen)
  2. When closing the modal of main content from published view - It changes the modal to publish view before closing (minor thing but seems like something is changing on the screen)
  3. When I click on republish, the form data gets filled based on the selected provider, but if I change the dropdown source, even if the provider is in localStorage, the form is not populated.

Let me know if you need more info. Thank you

minor_close_issue minor_close_issue

hey so for point 1 and 2, it has been a behaviour of the form, if we think this is not right then we can create a separate issue for it. And for point 3, when you're in the form, it does not read from the localStorage anymore so when you change to a different platform, it wont be re-populated

Signed-off-by: huongg <huongg1409@gmail.com>
@Huongg
Copy link
Contributor Author

Huongg commented Jun 6, 2024

FYI: link to the bug report for @ravi-kumar-pilla's comment 1 and 2: #1936

@ravi-kumar-pilla ravi-kumar-pilla self-requested a review June 6, 2024 18:23
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Huongg ... looks great 💯

Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
@Huongg Huongg merged commit 7733896 into main Jun 6, 2024
10 checks passed
@Huongg Huongg deleted the retrieve-viz-url branch June 6, 2024 20:19
@SajidAlamQB SajidAlamQB mentioned this pull request Jul 25, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to retrieve hosted shareable viz url
5 participants