Fix/gitpod #1862
Merged
Fix/gitpod #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
… ensure pyenv is available in the environment. Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
|
Can we add this guide somewhere, for product/design and other people who want to QA easily. @astrojuanlu - notion, contributing.md ? |
Signed-off-by: huongg <huongg1409@gmail.com>
noklam
approved these changes
Apr 17, 2024
|
Yes, please make this either a wiki page or add it to |
Signed-off-by: huongg <huongg1409@gmail.com>
Co-authored-by: Ravi Kumar Pilla <ravi_kumar_pilla@mckinsey.com> Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
noklam
reviewed
Apr 18, 2024
rashidakanchwala
approved these changes
Apr 18, 2024
Co-authored-by: Nok Lam Chan <nok_lam_chan@mckinsey.com> Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Co-authored-by: rashidakanchwala <37628668+rashidakanchwala@users.noreply.github.com> Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Co-authored-by: Ravi Kumar Pilla <ravi_kumar_pilla@mckinsey.com> Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Signed-off-by: huongg <huongg1409@gmail.com>
ravi-kumar-pilla
approved these changes
Apr 18, 2024
|
Spotted this when I tried to open a PR on GitPod: 
Should we open a new issue about it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1854
Development notes
Updated the gitpod workspace-full to the version which has both Node 18 and Python 3.11.5
QA notes
1. Click on the Open icon on the right
2. It will open the gitpod workspace automatically
3. Wait until both FE and BE are done with their build. You can check it by clicking on
frontendandbackend. This can take around 5 minutes to fully finish4. Final step is to ensure that you unblock the pop-up ads in the browser, then refresh the browser again. It should then build the kedro-viz in gitpod workspace
Checklist
RELEASE.mdfileTRIBUTING.md) guidelines
RELEASE.mdfile