Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace semver with packaging #1578

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Replace semver with packaging #1578

merged 6 commits into from
Oct 16, 2023

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Oct 13, 2023

Description

Resolves #1460

Development notes

  • Replaced all semver instances using packaging.version and VersionInfo.parse instances with packaging.version.parse

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review October 16, 2023 14:46
@ravi-kumar-pilla ravi-kumar-pilla requested review from noklam, MehdiNV and NeroOkwa and removed request for yetudada October 16, 2023 14:47
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one small comment about the release notes.

@@ -14,6 +14,7 @@ Please follow the established format:

## Bug fixes and other changes
- Fix improper display of 'run-command' inside the metadata panel. (#1569)
- Replace semver with packaging. (#1578)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add the other section here: ## Bug fixes and other changes.

@ravi-kumar-pilla ravi-kumar-pilla merged commit a53dd3e into main Oct 16, 2023
19 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the chore/replace-semver branch October 16, 2023 18:22
ravi-kumar-pilla added a commit that referenced this pull request Oct 16, 2023
@tynandebold tynandebold mentioned this pull request Oct 20, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace semver with packaging
3 participants