Inherit tags from nodes for modular pipelines #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravi-kumar-pilla
approved these changes
Sep 28, 2023
src/selectors/nodes.js
Outdated
| /** | ||
| * Retrieves tags associated with both nodes and their corresponding modular pipelines. | ||
| */ | ||
| export const getTaggedNodesAndModularPipelines = createSelector( |
There was a problem hiding this comment.
can we rename this to getTagsForNodesAndModularPipelines ?
SajidAlamQB
approved these changes
Sep 28, 2023
5 tasks
tynandebold
approved these changes
Sep 28, 2023
| /** | ||
| * Retrieves tags associated with both nodes and their corresponding modular pipelines. | ||
| */ | ||
| export const getTagsforNodesAndModularPipelines = createSelector( |
There was a problem hiding this comment.
Suggested change
| export const getTagsforNodesAndModularPipelines = createSelector( | |
| export const getTagsForNodesAndModularPipelines = createSelector( |
Comment on lines
+56
to
+57
| const modularPipelineIDs = nodeModularPipelines[nodeID] || []; | ||
| modularPipelineIDs.forEach((modularPipelineID) => { |
There was a problem hiding this comment.
Suggested change
| const modularPipelineIDs = nodeModularPipelines[nodeID] || []; | |
| modularPipelineIDs.forEach((modularPipelineID) => { | |
| const modularPipelineIDs = nodeModularPipelines[nodeID] || []; | |
| modularPipelineIDs.forEach((modularPipelineID) => { |
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #795
Development notes
We tried solving this issue in the backend but the way modular pipelines is computed in the backend is very complex. I thought maybe we can try solving it in the FE using selectors.
In this PR, we have a new selector called getTagsforNodesAndModularPipelines.This selector identifies nodes associated with specific tags and then propagates these tags to the corresponding modular pipeline(s) (nested as well) for each node.
QA notes
I have also added some tags to the demo project so we can test this.
Checklist
RELEASE.mdfile