Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Azure Event Grid as a new CloudEvent destination #5606

Merged
merged 20 commits into from
Apr 22, 2024
Merged

Introduce Azure Event Grid as a new CloudEvent destination #5606

merged 20 commits into from
Apr 22, 2024

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Mar 15, 2024 •
edited by tomkerkhove
Loading

Add Azure Event Grid as a new CloudEvent destination

Checklist

Relates to #3587
Relates to kedacore/keda-docs#1336

@SpiritZhou
Update
682eb9b 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
649792d 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update changelog.md
d32b2e2 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Fix
5868bde 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Fix
aef8497 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou requested a review from a team as a code owner March 15, 2024 08:39
This was referenced Mar 15, 2024
Merged
Merged
@JorTurFer
Copy link
Member

Looking good, only 2 inline comments

@SpiritZhou
Update
9245a7d 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@tomkerkhove tomkerkhove mentioned this pull request Mar 26, 2024
Closed
@SpiritZhou
Update
aed575e 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
988e131 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@zroubalik
Copy link
Member

zroubalik commented Apr 10, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@SpiritZhou
Merge branch 'main' into spiritzhou/azureeventgrid
6917970 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

It looks like os.Getenv("TF_AZURE_EVENT_GRID_ENDPOINT") is null in the test. Is there any method to check the env variable in the e2e test?

@SpiritZhou
Update
f5f8669 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
tomkerkhove
tomkerkhove reviewed Apr 15, 2024
View reviewed changes
tests/.env Outdated Show resolved Hide resolved
tests/eventemitter/azureeventgridtopic/azureeventgridtopic_test.go Outdated Show resolved Hide resolved
SpiritZhou and others added 2 commits April 15, 2024 15:12
@SpiritZhou @tomkerkhove
Update tests/.env
4bf81f7 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou @tomkerkhove
Update tests/eventemitter/azureeventgridtopic/azureeventgridtopic_tes…
5021401 
…t.go

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 15, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@SpiritZhou
Temp
831a0e3 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 16, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@SpiritZhou
Fix
cfafeae 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 16, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@tomkerkhove tomkerkhove mentioned this pull request Apr 16, 2024
Closed
35 tasks
@tomkerkhove
Copy link
Member

tomkerkhove commented Apr 16, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@SpiritZhou
Update
77eec43 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 16, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@SpiritZhou
Update
481c35a 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 16, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@SpiritZhou
Fix test
1976853 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Merge branch 'main' into spiritzhou/azureeventgrid
b1b2466
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Apr 16, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@tomkerkhove
Copy link
Member

Docs are fine, thanks!

JorTurFer
JorTurFer reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small nits inline

pkg/eventemitter/azure_event_grid_topic_handler.go Show resolved Hide resolved
pkg/eventemitter/eventemitter.go Outdated Show resolved Hide resolved
@SpiritZhou
Fix
f48ae1a 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@zroubalik
Copy link
Member

zroubalik commented Apr 19, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@tomkerkhove
Copy link
Member

tomkerkhove commented Apr 22, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@tomkerkhove
Copy link
Member

tomkerkhove commented Apr 22, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@tomkerkhove
Copy link
Member

tomkerkhove commented Apr 22, 2024 •
edited by github-actions bot
Loading

/run-e2e eventemitter
Update: You can check the progress here

@tomkerkhove tomkerkhove merged commit f7b2431 into kedacore:main Apr 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

@semgrep-app semgrep-app semgrep-app left review comments

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees

@zroubalik zroubalik

@JorTurFer JorTurFer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpiritZhou @JorTurFer @zroubalik @tomkerkhove