Set LeaderElectionNamespace to PodNamespace #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliaqel-stripe
changed the title
zroubalik
reviewed
Jan 18, 2024
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
aliaqel-stripe
force-pushed
the
aliaqel/issue-5404-outofcluster-leaderelection
branch
from
c40343f
to
571219d
Compare
|
/run-e2e |
|
/run-e2e |
zroubalik
approved these changes
Jan 18, 2024
|
/run-e2e |
JorTurFer
approved these changes
Jan 18, 2024
|
/skip-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the LeaderElectionNamespace on the controller runtime in keda-operator to use the PodNamespace so that leader election works in OutOfCluster mode. This is based on a similar change we had to make in karpenter
Couldn't find any general tests that test the operator but since this uses an existing utility and a parameter passed to the controller runtime, I don't think it's changing behavior enough to KEDA that it warrants a new test, but let me know and I'll happily write a new test!
I did validate manually in my own cluster and this worked.
Checklist
Fixes #5404