-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Finalization when other finalizers are in place #5317
Merged
zroubalik
merged 1 commit into
kedacore:main
from
similark:fix/argocd_finalizer_collisions
Jan 1, 2024
Merged
Fix Finalization when other finalizers are in place #5317
zroubalik
merged 1 commit into
kedacore:main
from
similark:fix/argocd_finalizer_collisions
Jan 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Or Koren <or.koren@similarweb.com>
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
Nice catch! |
JorTurFer
approved these changes
Dec 26, 2023
/run-e2e internal |
/run-e2e internal |
Not sure the failing check is relevant to my change 🤔 |
zroubalik
approved these changes
Dec 28, 2023
/run-e2e pause_scaledjob_test |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
Signed-off-by: Or Koren <or.koren@similarweb.com>
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
Signed-off-by: Or Koren <or.koren@similarweb.com> Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webhook's
isRemovingFinalizer
func should check whether the change is less finalizers, obviously, and not specifically check whether the old Scaledobject has exactly 1 finalizer AND the new Scaled object has exactly 0.This is to fix a use case in which ArgoCD performs cascading deletion which translates to a
foregroundDeletion
finalizer being added to the object, causing the current webhook implementation enter a loop of update-validate ("if not isRemovingFinalizer then update") instead of proceeding with deletion.Checklist