Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Finalization when other finalizers are in place #5317

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

similark
Copy link
Contributor

@similark similark commented Dec 26, 2023

The webhook's isRemovingFinalizer func should check whether the change is less finalizers, obviously, and not specifically check whether the old Scaledobject has exactly 1 finalizer AND the new Scaled object has exactly 0.
This is to fix a use case in which ArgoCD performs cascading deletion which translates to a foregroundDeletion finalizer being added to the object, causing the current webhook implementation enter a loop of update-validate ("if not isRemovingFinalizer then update") instead of proceeding with deletion.

Checklist

Signed-off-by: Or Koren <or.koren@similarweb.com>
@similark similark requested a review from a team as a code owner December 26, 2023 14:39
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@JorTurFer
Copy link
Member

Nice catch!
Thanks for the fix :)

@JorTurFer
Copy link
Member

JorTurFer commented Dec 26, 2023

/run-e2e internal
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Dec 26, 2023

/run-e2e internal
Update: You can check the progress here

@similark
Copy link
Contributor Author

Not sure the failing check is relevant to my change 🤔

@zroubalik
Copy link
Member

zroubalik commented Dec 28, 2023

/run-e2e pause_scaledjob_test
Update: You can check the progress here

@zroubalik zroubalik merged commit 8e2e9f4 into kedacore:main Jan 1, 2024
19 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 3, 2024
Signed-off-by: Or Koren <or.koren@similarweb.com>
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Signed-off-by: Or Koren <or.koren@similarweb.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants