Fix issue where paused annotation being set to false still leads to scaled objects/jobs being paused #5257

nappelson · 2023-12-06T00:44:48Z

This PR adds "bool parsing" logic to the paused annotation. Keda docs suggests pausing scaledjobs/objects by setting the paused annotation to true. When I tried resuming the object by setting the annotation to false, I noticed the object remained paused.

Just for reference (https://go.dev/src/strconv/atob.go)

// ParseBool returns the boolean value represented by the string.
// It accepts 1, t, T, TRUE, true, True, 0, f, F, FALSE, false, False.

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5215

github-actions · 2023-12-06T00:45:00Z

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Our contribution guide

…caled objects/jobs being paused commit 9eafdb6 Merge: 78a7479 bd91050 Author: Nate Appelson <nate.appelson@regrow.ag> Date: Tue Dec 5 21:30:08 2023 -0500 Merge branch 'main' of github.com:nappelson/keda into 5215-fix-paused-annotation Signed-off-by: Nate Appelson <nate.appelson@regrow.ag> commit 78a7479 Author: Nate Appelson <nate.appelson@regrow.ag> Date: Tue Dec 5 21:15:52 2023 -0500 Empty-Commit to trigger CI commit d4530bd Author: Nate Appelson <nate.appelson@regrow.ag> Date: Tue Dec 5 21:00:11 2023 -0500 Fix issue where paused annotation being set to false still leads to scaled objects/jobs being paused Signed-off-by: Nate Appelson <nate.appelson@regrow.ag> Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

nappelson · 2023-12-06T03:10:47Z

@zroubalik curious if you have thoughts on why the TestPredictKubeGetMetrics may be failing here... when I check out main directly and run the tests on my dev container i see that test fail as well.

The main-build appears to be passing on CI so I'm not 100% sure what is going on. Let me know if I'm missing something obvious. Happy to talk to someone else too. Otherwise, I'll dig more into what could be happening here.

zroubalik · 2023-12-07T16:07:10Z

@zroubalik curious if you have thoughts on why the TestPredictKubeGetMetrics may be failing here... when I check out main directly and run the tests on my dev container i see that test fail as well.

The main-build appears to be passing on CI so I'm not 100% sure what is going on. Let me know if I'm missing something obvious. Happy to talk to someone else too. Otherwise, I'll dig more into what could be happening here.

Most likely a flaky test, pls disregard this one.

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

…a into 5215-fix-paused-annotation Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

zroubalik · 2023-12-15T11:07:14Z

/run-e2e internals
Update: You can check the progress here

nappelson · 2023-12-15T16:06:02Z

/run-e2e internals Update: You can check the progress here

@zroubalik thanks for running these - curious why they failed remotely. I also see one of the controller tests is failing. I'll fix that shortly!

nappelson · 2023-12-15T16:06:27Z

/run-e2e internals Update: You can check the progress here

@zroubalik thanks for running these! I also see one of the controller tests is failing. I'll fix that and the e2e test shortly.

zroubalik · 2023-12-15T16:16:21Z

The problem seems to be in pause_scaledjob/pause_scaledjob_test.go let me rerun the test.

zroubalik · 2023-12-15T16:16:32Z

/run-e2e pause_scaledjob
Update: You can check the progress here

zroubalik · 2023-12-15T16:18:48Z

For unit tests it is as you said:

[FAIL] ScaledObjectController [It] scaledobject paused condition status changes to true on annotation
  /__w/keda/keda/controllers/keda/scaledobject_controller_test.go:935
  [FAIL] ScaledObjectController [It] deletes hpa when scaledobject has pause annotation
  /__w/keda/keda/controllers/keda/scaledobject_controller_test.go:1132

Could you please also rebase your PR? We have merged some annotations based PR: #5282

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

…annotation Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

nappelson · 2023-12-19T02:06:36Z

For unit tests it is as you said:

[FAIL] ScaledObjectController [It] scaledobject paused condition status changes to true on annotation
  /__w/keda/keda/controllers/keda/scaledobject_controller_test.go:935
  [FAIL] ScaledObjectController [It] deletes hpa when scaledobject has pause annotation
  /__w/keda/keda/controllers/keda/scaledobject_controller_test.go:1132

Could you please also rebase your PR? We have merged some annotations based PR: #5282

@zroubalik this should be ready again. Appreciate your patience.

zroubalik · 2023-12-19T17:06:11Z

/run-e2e internals
Update: You can check the progress here

zroubalik

LGTM, thanks a lot for the contribution! Great job.

zroubalik

Do you think you can also update docs for 2.13 mentioning that true/false works with the annotation?

CHANGELOG.md

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

nappelson · 2023-12-21T23:15:12Z

Do you think you can also update docs for 2.13 mentioning that true/false works with the annotation?

kedacore/keda-docs#1283 just created this

…annotation Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

…caled objects/jobs being paused (kedacore#5257) Signed-off-by: Nate Appelson <nate.appelson@regrow.ag> Signed-off-by: anton.lysina <alysina@gmail.com>

nappelson force-pushed the 5215-fix-paused-annotation branch 6 times, most recently from cf63b33 to 78a7479 Compare December 6, 2023 02:21

nappelson force-pushed the 5215-fix-paused-annotation branch from 9eafdb6 to 8cc7b9e Compare December 6, 2023 02:52

nappelson added 3 commits December 8, 2023 17:49

Add test to paused_scaleobject_explicitly_test

4fec258

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

Add test to paused_scaleobject_explicitly_test

60a00d2

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

update changelog

71994d5

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

nappelson marked this pull request as ready for review December 14, 2023 22:57

Merge branch 'main' into 5215-fix-paused-annotation

8a9eed1

nappelson requested a review from a team as a code owner December 14, 2023 22:57

nappelson added 2 commits December 14, 2023 18:13

update changelog

cd5a6a1

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

Merge branch '5215-fix-paused-annotation' of github.com:nappelson/ked…

b0f3a4d

…a into 5215-fix-paused-annotation Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

nappelson added 2 commits December 18, 2023 19:18

fix tests

291c71e

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

Merge branch 'main' of github.com:kedacore/keda into 5215-fix-paused-…

bf27e6a

…annotation Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

nappelson force-pushed the 5215-fix-paused-annotation branch from 9f13d3f to bf27e6a Compare December 19, 2023 00:18

fix tests

3dca32a

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

zroubalik approved these changes Dec 21, 2023

View reviewed changes

zroubalik reviewed Dec 21, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

update changelog

8b037a8

Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

Merge branch 'main' of github.com:kedacore/keda into 5215-fix-paused-…

7c43b8b

…annotation Signed-off-by: Nate Appelson <nate.appelson@regrow.ag>

nappelson requested a review from zroubalik December 21, 2023 23:17

nappelson mentioned this pull request Dec 21, 2023

Specify that you can unpause by setting autoscaling.keda.sh/paused=false kedacore/keda-docs#1283

Merged

1 task

zroubalik approved these changes Dec 22, 2023

View reviewed changes

zroubalik merged commit df16ac1 into kedacore:main Dec 22, 2023
18 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue where paused annotation being set to false still leads to scaled objects/jobs being paused #5257

Fix issue where paused annotation being set to false still leads to scaled objects/jobs being paused #5257

nappelson commented Dec 6, 2023 •

edited

Loading

github-actions bot commented Dec 6, 2023

nappelson commented Dec 6, 2023

zroubalik commented Dec 7, 2023

zroubalik commented Dec 15, 2023 •

edited by github-actions bot

Loading

nappelson commented Dec 15, 2023

nappelson commented Dec 15, 2023

zroubalik commented Dec 15, 2023

zroubalik commented Dec 15, 2023 •

edited by github-actions bot

Loading

zroubalik commented Dec 15, 2023 •

edited

Loading

nappelson commented Dec 19, 2023

zroubalik commented Dec 19, 2023 •

edited by github-actions bot

Loading

zroubalik left a comment

zroubalik left a comment

nappelson commented Dec 21, 2023

Fix issue where paused annotation being set to false still leads to scaled objects/jobs being paused #5257

Fix issue where paused annotation being set to false still leads to scaled objects/jobs being paused #5257

Conversation

nappelson commented Dec 6, 2023 • edited Loading

Checklist

github-actions bot commented Dec 6, 2023

nappelson commented Dec 6, 2023

zroubalik commented Dec 7, 2023

zroubalik commented Dec 15, 2023 • edited by github-actions bot Loading

nappelson commented Dec 15, 2023

nappelson commented Dec 15, 2023

zroubalik commented Dec 15, 2023

zroubalik commented Dec 15, 2023 • edited by github-actions bot Loading

zroubalik commented Dec 15, 2023 • edited Loading

nappelson commented Dec 19, 2023

zroubalik commented Dec 19, 2023 • edited by github-actions bot Loading

zroubalik left a comment

Choose a reason for hiding this comment

zroubalik left a comment

Choose a reason for hiding this comment

nappelson commented Dec 21, 2023

nappelson commented Dec 6, 2023 •

edited

Loading

zroubalik commented Dec 15, 2023 •

edited by github-actions bot

Loading

zroubalik commented Dec 15, 2023 •

edited by github-actions bot

Loading

zroubalik commented Dec 15, 2023 •

edited

Loading

zroubalik commented Dec 19, 2023 •

edited by github-actions bot

Loading