Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove deprecated AAD-Pod-Identity and AWS-KIAM auths #640

Merged
merged 1 commit into from
May 6, 2024
Merged

chore: Remove deprecated AAD-Pod-Identity and AWS-KIAM auths #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions keda/templates/crds/crd-clustertriggerauthentications.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,10 @@ spec:
provider:
description: PodIdentityProvider contains the list of providers
enum:
- azure
- azure-workload
- gcp
- aws
- aws-eks
- aws-kiam
- none
type: string
roleArn:
Expand Down Expand Up @@ -277,12 +275,10 @@ spec:
provider:
description: PodIdentityProvider contains the list of providers
enum:
- azure
- azure-workload
- gcp
- aws
- aws-eks
- aws-kiam
- none
type: string
roleArn:
Expand Down Expand Up @@ -401,12 +397,10 @@ spec:
provider:
description: PodIdentityProvider contains the list of providers
enum:
- azure
- azure-workload
- gcp
- aws
- aws-eks
- aws-kiam
- none
type: string
roleArn:
Expand Down Expand Up @@ -528,12 +522,10 @@ spec:
provider:
description: PodIdentityProvider contains the list of providers
enum:
- azure
- azure-workload
- gcp
- aws
- aws-eks
- aws-kiam
- none
type: string
roleArn:
Expand Down
8 changes: 0 additions & 8 deletions keda/templates/crds/crd-triggerauthentications.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,10 @@ spec:
provider:
description: PodIdentityProvider contains the list of providers
enum:
- azure
- azure-workload
- gcp
- aws
- aws-eks
- aws-kiam
- none
type: string
roleArn:
Expand Down Expand Up @@ -276,12 +274,10 @@ spec:
provider:
description: PodIdentityProvider contains the list of providers
enum:
- azure
- azure-workload
- gcp
- aws
- aws-eks
- aws-kiam
- none
type: string
roleArn:
Expand Down Expand Up @@ -400,12 +396,10 @@ spec:
provider:
description: PodIdentityProvider contains the list of providers
enum:
- azure
- azure-workload
- gcp
- aws
- aws-eks
- aws-kiam
- none
type: string
roleArn:
Expand Down Expand Up @@ -527,12 +521,10 @@ spec:
provider:
description: PodIdentityProvider contains the list of providers
enum:
- azure
- azure-workload
- gcp
- aws
- aws-eks
- aws-kiam
- none
type: string
roleArn:
Expand Down
3 changes: 0 additions & 3 deletions keda/templates/manager/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ spec:
name: {{ .Values.operator.name }}
app.kubernetes.io/name: {{ .Values.operator.name }}
{{- include "keda.labels" . | indent 8 }}
{{- if .Values.podIdentity.activeDirectory.identity }}
aadpodidbinding: {{ .Values.podIdentity.activeDirectory.identity }}
{{- end }}
{{- if .Values.podLabels.keda }}
{{- toYaml .Values.podLabels.keda | nindent 8 }}
{{- end }}
Expand Down
6 changes: 0 additions & 6 deletions keda/templates/metrics-server/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,9 @@ spec:
app: {{ .Values.operator.name }}-metrics-apiserver
app.kubernetes.io/name: {{ .Values.operator.name }}-metrics-apiserver
{{- include "keda.labels" . | indent 8 }}
{{- if .Values.podIdentity.activeDirectory.identity }}
aadpodidbinding: {{ .Values.podIdentity.activeDirectory.identity }}
{{- end }}
{{- if .Values.podLabels.metricsAdapter }}
{{- toYaml .Values.podLabels.metricsAdapter | nindent 8}}
{{- end }}
{{- if .Values.podIdentity.azureWorkload.enabled }}
azure.workload.identity/use: "true"
{{- end }}
{{- if or .Values.additionalAnnotations .Values.podAnnotations.metricsAdapter (and .Values.prometheus.metricServer.enabled ( not (or .Values.prometheus.metricServer.podMonitor.enabled .Values.prometheus.metricServer.serviceMonitor.enabled )) )}}
annotations:
{{- if .Values.additionalAnnotations }}
Expand Down
6 changes: 0 additions & 6 deletions keda/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,12 +317,6 @@ serviceAccount:
annotations: {}

podIdentity:
activeDirectory:
# Set to the value of the Azure Active Directory Pod Identity
# See https://keda.sh/docs/concepts/authentication/#azure-pod-identity
# This will be set as a label on the KEDA Pod(s)
# -- Identity in Azure Active Directory to use for Azure pod identity
identity: ""
azureWorkload:
# -- Set to true to enable Azure Workload Identity usage.
# See https://keda.sh/docs/concepts/authentication/#azure-workload-identity
Expand Down
Loading