test changeSince/until ws load #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanbracinik
force-pushed
the
ct-1688-add-chaned-parameter-load-to-ws
branch
from
8f9b4e1
to
c134196
Compare
jirkasemmler
reviewed
Aug 9, 2024
jirkasemmler
requested changes
Aug 9, 2024
| 'incremental' => true, | ||
| ], | ||
| ); | ||
| $timesOfRun['fistImportTime'] = time(); |
There was a problem hiding this comment.
nechces tady neajke delaye?
There was a problem hiding this comment.
Hm neprislo mi to potreba
jirkasemmler
reviewed
Aug 9, 2024
| /** | ||
| * @dataProvider sinceDataProvider | ||
| */ | ||
| public function testWorkspaceLoadFilterByChanged(?string $changedSince, ?string $changedUntil, int $expectedResult): void |
There was a problem hiding this comment.
chybi mi tady test na nejakej bordel (jakoze spatny vstup)
romanbracinik
force-pushed
the
ct-1688-add-chaned-parameter-load-to-ws
branch
from
dfa72fe
to
d68c565
Compare
jirkasemmler
approved these changes
Aug 13, 2024
Co-authored-by: Jiří Semmler <13363655+jirkasemmler@users.noreply.github.com>
romanbracinik
force-pushed
the
ct-1688-add-chaned-parameter-load-to-ws
branch
from
d68c565
to
00271a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: CT-1688
KBC: https://github.com/keboola/connection/pull/5204
Before asking for review make sure that:
Checklist
Release