Merge pull request #1390 from keboola/zajca-ct-1693

CT-1693 testRefreshTablesInformation test alias update
keboola · Aug 21, 2024 · 4ed66bc · 4ed66bc
2 parents 8ec3b5a + cd78fec
commit 4ed66bc
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 18 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -750,11 +750,21 @@ parameters:
 			count: 1
 			path: src/Keboola/StorageApi/Client.php
 
+		-
+			message: "#^Method Keboola\\\\StorageApi\\\\Client\\:\\:validateColumnNames\\(\\) has no return type specified\\.$#"
+			count: 1
+			path: src/Keboola/StorageApi/Client.php
+
 		-
 			message: "#^Method Keboola\\\\StorageApi\\\\Client\\:\\:waitForJob\\(\\) has parameter \\$jobId with no type specified\\.$#"
 			count: 1
 			path: src/Keboola/StorageApi/Client.php
 
+		-
+			message: "#^Method Keboola\\\\StorageApi\\\\Client\\:\\:webalizeColumnNames\\(\\) has no return type specified\\.$#"
+			count: 1
+			path: src/Keboola/StorageApi/Client.php
+
 		-
 			message: "#^Method Keboola\\\\StorageApi\\\\Client\\:\\:webalizeDisplayName\\(\\) has no return type specified\\.$#"
 			count: 1
@@ -2510,11 +2520,6 @@ parameters:
 			count: 1
 			path: tests/Backend/Export/ExportParamsTest.php
 
-		-
-			message: "#^Unreachable statement \\- code above always terminates\\.$#"
-			count: 1
-			path: tests/Backend/ExternalBuckets/SnowflakeBucketsRefreshTablesInformationTest.php
-
 		-
 			message: "#^Argument of an invalid type mixed supplied for foreach, only iterables are supported\\.$#"
 			count: 1
@@ -5224,12 +5229,3 @@ parameters:
 			message: "#^Parameter \\#1 \\$filename of function file_get_contents expects string, string\\|false given\\.$#"
 			count: 1
 			path: tests/bootstrap.php
-		-
-			message: "#^Method Keboola\\\\StorageApi\\\\Client\\:\\:webalizeColumnNames\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: src/Keboola/StorageApi/Client.php
-
-		-
-			message: "#^Method Keboola\\\\StorageApi\\\\Client\\:\\:validateColumnNames\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: src/Keboola/StorageApi/Client.php
diff --git a/tests/Backend/ExternalBuckets/SnowflakeBucketsRefreshTablesInformationTest.php b/tests/Backend/ExternalBuckets/SnowflakeBucketsRefreshTablesInformationTest.php
@@ -26,7 +26,6 @@ public function testRefreshTablesInformationEndpointExists(): void
 
     public function testRefreshTablesInformation(): void
     {
-        $this->markTestSkipped('Test is not working, needs to be fixed; CT-1691');
         $createdTableRows = 10;
 
         $workspaces = new Workspaces($this->_client);
@@ -41,6 +40,7 @@ public function testRefreshTablesInformation(): void
         $bucket = $this->_client->getBucket($bucketId);
 
         $tableId = $this->createTableWithRandomData('refresh-tables-information-test-table', $createdTableRows, 2);
+        $aliasId = $this->_client->createAliasTable($bucketId, $tableId, 'alias');
         $table = $this->_client->getTable($tableId);
 
         $rowsCount = $table['rowsCount'];
@@ -58,6 +58,13 @@ public function testRefreshTablesInformation(): void
             ),
         );
 
+        $db->executeQuery(
+            sprintf(
+                'USE ROLE %s;',
+                SnowflakeQuote::quoteSingleIdentifier($workspace['connection']['database']),
+            ),
+        );
+
         $db->executeQuery(
             sprintf(
                 'USE WAREHOUSE %s;',
@@ -81,7 +88,7 @@ public function testRefreshTablesInformation(): void
 
         $db->executeQuery(
             sprintf(
-                'INSERT INTO %s ("col_1","col_2") VALUES (\'testvalue 1\', \'testvalue 2\')',
+                'INSERT INTO %s ("col_1","col_2") VALUES (\'testvalue 1\', \'testvalue 2\'),(\'testvalue 1\', \'testvalue 2\')',
                 SnowflakeQuote::quoteSingleIdentifier($table['name']),
             ),
         );
@@ -91,15 +98,25 @@ public function testRefreshTablesInformation(): void
         $bClient->refreshTableInformationInBucket($bucketId);
 
         $refreshedTable = $this->_client->getTable($tableId);
+        $refreshedTableAlias = $this->_client->getTable($aliasId);
 
-        $this->assertEquals($rowsCount + 1, $refreshedTable['rowsCount']);
+        $this->assertEquals($rowsCount + 2, $refreshedTable['rowsCount']);
+        $this->assertEquals($refreshedTable['rowsCount'], $refreshedTableAlias['rowsCount']);
         // TODO: check dataSizeBytes did not change but rowsCount did
 //        $this->assertNotEquals($dataSizeBytes, $refreshedTable['dataSizeBytes']);
+//        $this->assertNotEquals($refreshedTable['dataSizeBytes'], $refreshedTableAlias['dataSizeBytes']);
 
-        $this->_client->dropTable($tableId);
+        $this->_client->dropTable($tableId, ['force' => true]);
         $this->_client->dropBucket($bucketId);
         $workspaces->deleteWorkspace($workspace['id']);
 
+        $db->executeQuery(
+            sprintf(
+                'USE ROLE %s;',
+                SnowflakeQuote::quoteSingleIdentifier((string) getenv('SNOWFLAKE_USER')),
+            ),
+        );
+
         $db->executeQuery(
             sprintf(
                 'REVOKE ROLE %s FROM USER %s;',