PHP8 for V1 #51
PHP8 for V1 #51
Conversation
zajca
force-pushed
the
zajca-php8-for-v1
branch
from
91deb16
to
027b0e9
Compare
zajca
requested review from
a team and
martinjunger
and removed request for
a team and
martinjunger
composer.json
Outdated
| "tests": "phpunit", | ||
| "ci": [ | ||
| "@composer validate --strict", | ||
| "@build" |
There was a problem hiding this comment.
v buildu to pise
Run composer ci
./composer.json is valid
You made a reference to a non-existent script@build
Jakej byl zamer s tim @build - pustit phpunit testy? Potom by tam mel byt @tests ;-)
There was a problem hiding this comment.
bylo by fajn, kdyby to ten skript skoncil, zajimavy ze to jen vypise warning a frci to dal...
There was a problem hiding this comment.
To je ale vlastnost composeru když je tam ta stage není nebo je prázdná tak vrátí status code 0
tests/CsvFileErrorsTest.php
Outdated
| if (PHP_MAJOR_VERSION > 7) { | ||
| $this->markTestSkipped(); | ||
| } |
There was a problem hiding this comment.
proc tohle? Slo by do toho skipped pridat description?
| @@ -40,7 +43,7 @@ public function invalidFileNameProvider() | |||
| { | |||
| return [ | |||
| ["", 'Filename cannot be empty'], | |||
| ["\0", 'fopen() expects parameter 1 to be a valid path, string given'], | |||
| // ["\0", 'fopen() expects parameter 1 to be a valid path, string given'], | |||
There was a problem hiding this comment.
co s timhle, smazat nebo pridat komentar proc je to zakomentovany?
There was a problem hiding this comment.
v php8 sa to chová trochu jinak a nejde to moc rozumně vyřesit bez hacků a ztráty dalšího času pro knihovnu co je obsolete.
|
Koukam jeste do tech testu, je tam 1 risky: Bylo by dobry do toho testu pridat $this->expectNotToPerformAssertions();Edit: ale vlastne je to pro starou verzi |
No description provided.