Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add flag header for download table command #1892

Merged
merged 4 commits into from
Jul 11, 2024
Merged

feat: Add flag header for download table command #1892

merged 4 commits into from
Jul 11, 2024

Conversation

hosekpeter
Copy link
Contributor

@hosekpeter hosekpeter commented Jul 8, 2024 •
edited by jira bot
Loading

Jira: PSGO-295

Changes:

  • added new flag header
  • added more tests for this command

Added a new field header for download table command. This flag adds column names to csv file result.

@hosekpeter hosekpeter added the CLI label Jul 8, 2024
@hosekpeter hosekpeter force-pushed the ph-PSGO-295 branch 2 times, most recently from 2f867ea to d576b74 Compare July 8, 2024 12:57
@hosekpeter hosekpeter marked this pull request as ready for review July 8, 2024 13:08
@hosekpeter hosekpeter requested review from a team and removed request for a team July 8, 2024 14:41
Matovidlo
Matovidlo approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Matovidlo Matovidlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/pkg/service/cli/cmd/remote/table/download/cmd.go Outdated Show resolved Hide resolved
@hosekpeter hosekpeter requested a review from Matovidlo July 9, 2024 14:56
Matovidlo
Matovidlo approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Matovidlo Matovidlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hosekpeter hosekpeter merged commit 1a7b963 into main Jul 11, 2024
13 checks passed
@hosekpeter hosekpeter deleted the ph-PSGO-295 branch July 11, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matovidlo Matovidlo Matovidlo approved these changes

@jachym-tousek-keboola jachym-tousek-keboola jachym-tousek-keboola approved these changes

Assignees
No one assigned
Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hosekpeter @Matovidlo @jachym-tousek-keboola