Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(visit): Pre-generate visitor code #15

Closed
wants to merge 82 commits into from
Closed

Conversation

kdy1
Copy link
Owner

@kdy1 kdy1 commented Jul 16, 2024

Description:

This would improve compile time by a margin, and this is a refactoring that should be done before applying swc_allocator::boxed::Box to ES AST.

TODOs

  • Use AstPath.with_guard in fold_children_with.
  • Implement FoldWith for Option<T>, Box<T>, and Vec<T> if required.
  • Remove swc_visit_macros.
  • Implement Fold for either::Either and several more types.
  • Remove dependencies of swc_ecma_visit.

Related issue:

Copy link
Owner Author

kdy1 commented Jul 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kdy1 and the rest of your teammates on Graphite Graphite

@kdy1 kdy1 changed the title Add a crate refactor(visit): Pre-generate visitor code Jul 16, 2024
@kdy1 kdy1 marked this pull request as ready for review July 16, 2024 10:30
@kdy1 kdy1 closed this Jul 16, 2024
@kdy1 kdy1 deleted the pre-codegen-visitor branch July 16, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish pre-codegened version of AST/visitor crates
1 participant