Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename filter init param allow to something like except or exempt #29

Open
kdabir opened this issue Jun 28, 2016 · 0 comments
Open

Rename filter init param allow to something like except or exempt #29

kdabir opened this issue Jun 28, 2016 · 0 comments
Labels
runtime

Comments

@kdabir
Copy link
Owner

kdabir commented Jun 28, 2016

Which means those urls matching that pattern will be exempted by the Filter and it will let them pass through. allow sounds too generic and feels as if allow takes precedence over block.
@kdabir kdabir added the runtime label Jun 28, 2016
kdabir added a commit that referenced this issue Jun 29, 2016
@kdabir
#29 clarify the usage, rename the param, add tests, small performance…
f06b02a 
… optimizations without affecting functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdabir