Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log message in the test report #361

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 30, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #358

feat: add log message in the test report

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10159006894

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 32.233%

Files with Coverage Reduction New Missed Lines %
pkg/tools/testing/testing.go 1 40.35%
Totals Coverage Status
Change from base Build 10138345203: 0.006%
Covered Lines: 5577
Relevant Lines: 17302

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit c647f95 into kcl-lang:main Jul 30, 2024
10 of 11 checks passed
@Peefy Peefy deleted the feat-add-log-message-in-test-report branch July 30, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add log message output for the testing API and tool. support Go API for GetSchemaTypeMapping
3 participants