Skip to content

Commit

Permalink
ci: upgrade superlinter from v5 to v7
Browse files Browse the repository at this point in the history
  • Loading branch information
kamontat committed Sep 7, 2024
1 parent e5947c3 commit edd9208
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 24 deletions.
2 changes: 1 addition & 1 deletion .github/linters/.markdown-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ default: true
# https://github.com/DavidAnson/markdownlint/blob/v0.33.0/doc/md007.md
MD007:
# Spaces for indent
indent: 4
indent: 2

# MD013/line-length : Line length
# https://github.com/DavidAnson/markdownlint/blob/v0.33.0/doc/md013.md
Expand Down
47 changes: 27 additions & 20 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,39 +68,46 @@ jobs:
run-tests: true
lintcheck:
runs-on: ubuntu-latest
permissions:
contents: write
statuses: write
steps:
- name: Checkout source code
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Linting
## https://github.com/super-linter/super-linter#slim-image
uses: super-linter/super-linter/slim@v5
uses: super-linter/super-linter/slim@v7
env:
DEFAULT_BRANCH: ${{ env.DEFAULT_BRANCH }}
VALIDATE_ALL_CODEBASE: false
IGNORE_GITIGNORED_FILES: true
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
YAML_CONFIG_FILE: .yamllint.yml
YAML_ERROR_ON_WARNING: true
# Disabled javascript/typescript as we have lint on rushjs
VALIDATE_JAVASCRIPT_ES: false
VALIDATE_JAVASCRIPT_STANDARD: false
VALIDATE_JSX: false
VALIDATE_TYPESCRIPT_ES: false
VALIDATE_TYPESCRIPT_STANDARD: false
VALIDATE_TSX: false
# Disabled json validation as issue #30
VALIDATE_JSON: false
# The overrided config cannot resolve to correct path
# so we disabled it for now.
# For now, we only have single project using css linter
# so we will run it manually on local.
VALIDATE_CSS: false
IGNORE_GITIGNORED_FILES: true
IGNORE_GENERATED_FILES: true
# For markdownlint, as it cannot exclude file from config file
# exclude reviews file because it autogen file
FILTER_REGEX_EXCLUDE: common/reviews/api/*

VALIDATE_ALL_CODEBASE: false
VALIDATE_CHECKOV: true
VALIDATE_EDITORCONFIG: true
VALIDATE_ENV: true
VALIDATE_GITHUB_ACTIONS: true
VALIDATE_GITLEAKS: true
VALIDATE_JSCPD: true
VALIDATE_NATURAL_LANGUAGE: true
VALIDATE_BASH: true
VALIDATE_BASH_EXEC: true
VALIDATE_SHELL_SHFMT: true
VALIDATE_XML: true
VALIDATE_JSON_PRETTIER: true
VALIDATE_JSONC: true
VALIDATE_MARKDOWN_PRETTIER: true
VALIDATE_MARKDOWN: true
VALIDATE_YAML: true
YAML_CONFIG_FILE: .yamllint.yml
YAML_ERROR_ON_WARNING: true

testing:
runs-on: ubuntu-latest
needs:
Expand All @@ -120,7 +127,7 @@ jobs:
with:
command: test
- name: Analysis packages
uses: SonarSource/sonarcloud-github-action@v2.1.1
uses: SonarSource/sonarcloud-github-action@v3.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions DEV.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

## Required features

- typescript / javascript
- TypeScript / JavaScript
- lint-staged && husky (git-hooks)
- linters
- eslint
- ESLint
- prettier
- commitlint && commitizen
- test framework (select one)
Expand All @@ -19,5 +19,5 @@
- package generator
- release
- conventional commits
- indenpendent versions
- independent versions
- support release by GitHub Actions

0 comments on commit edd9208

Please sign in to comment.