-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#148 Wake on LAN via CLI #149
Conversation
FritzHosts provides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Due to missing hardware I'm unable to test the code but I have added some comments about the implementation. Also I suggest to rename the module to something like "fritzwakeonlan.py". This way it is obvious what the module is about (and does not sound and read like a miss-spelled "fritzwool" – whatever that may be ;).
Thanks for your contribution.
@kbr sorry for the slight delay 🙂 I've worked on your feedback and also ran the code locally: Successfully wakes up my diskstation:
Gives error when hostname is not known at Fritzbox:
|
If you feel like shaping the comments a bit more, please go ahead. |
I would be really interested in this. Is there any progress? |
See #195 |
see issue #148 for details