Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for time-sensitive notifications & categories #1905

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for time-sensitive notifications & categories #1905

wants to merge 1 commit into from

Conversation

DustinBrett
Copy link

Support for time-sensitive notifications & categories
7b62f2a 
- Enabling “immediate” sets highest  priority and applies a full screen intent to the notification
    - https://developer.android.com/training/notify-user/time-sensitive
- Ability to set “category” of notification
    - https://developer.android.com/training/notify-user/build-notification#system-category
- Create “immediate” channel with highest importance
    - https://developer.android.com/guide/topics/ui/notifiers/notifications#Heads-up
- Added provider authority bug fix
    - katzer@caff55e#r35996436
@GitToTheHub
Copy link
Collaborator

Hi, thanks for your PR, but this is not a good realisation. In future, channels should be configurable and if a notification will bring up the app as full screen intent should be a configuraton point also and not bound to a "immediate" property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DustinBrett @GitToTheHub