Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less type safety: remove Handler::Msg assoc. type #309

Merged
merged 47 commits into from
Apr 26, 2022
Merged

Less type safety: remove Handler::Msg assoc. type #309

merged 47 commits into from
Apr 26, 2022

Commits on Apr 25, 2022

  1. Configuration menu
    Copy the full SHA
    f2bc440 View commit details
    Browse the repository at this point in the history
  2. Remove "Received by ..." message route tracing

    This is impossible with the new message model. No big loss.
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    ae6a8e4 View commit details
    Browse the repository at this point in the history
  3. ComboBox, SubMenu: do not handle Response::Select

    This is not emitted by their children
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    c7a6ca0 View commit details
    Browse the repository at this point in the history
  4. Remove #[widget(update = f)]

    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    1b315f8 View commit details
    Browse the repository at this point in the history
  5. Remove Response::Update

    This breaks ComboBox and automatic updating of data
    through view widgets (to be fixed later).
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    9cc2861 View commit details
    Browse the repository at this point in the history
  6. Remove Handler::Msg type parameter

    This is a big revision to event handling, allowing multiple
    simultaneous messages from children and removing the need to
    parametrize many widgets over the message type.
    
    Incomplete: new Handler::on_message method not called yet.
    
    Remove Response::Msg, VoidMsg, #[derive(VoidMsg)]
    Replace event::ChildMsg with IndexMsg, SelectMsg
    Remove Updatable trait; add SingleData::on_message, etc.
    Remove #[widget(flatmap_msg=.., map_msg=.., use_msg=.., discard_msg)]
    make_widget!: remove -> message-type bound
    AdaptWidget: remove map_void_msg, map_msg_discard; adjust map_msg
    Button, etc...: event closure no longer returns Option<M>
    Grid, List: now push IndexMsg given a child message
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    08768da View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4713928 View commit details
    Browse the repository at this point in the history
  8. Remove #[widget{ msg = T; }]

    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    15f7956 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1bdaabc View commit details
    Browse the repository at this point in the history
  10. Replace Response::Select with SelectMsg

    Rename widgets::view::SelectMsg → SelectionMsg
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    4a025e3 View commit details
    Browse the repository at this point in the history
  11. Replace Response::Scrolled, Pan, Focus

    New Scroll enum, EventMgr::set_scroll and Handler::scroll methods
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    e81bdbb View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8d16fca View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ca1f392 View commit details
    Browse the repository at this point in the history
  14. Remove SendEvent trait; new EventMgr::send method

    This gets lots of things working again, but many bugs remain.
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    1e25789 View commit details
    Browse the repository at this point in the history
  15. ComboBox: push accelerator keys to a new layer

    This prevents keys activating by combobox menu items from
    doing anything unless the menu is already open, which is
    the same behaviour as used by menus.
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    f66b3b0 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c726445 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e7eebc8 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    d57ed01 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    8c230ad View commit details
    Browse the repository at this point in the history
  20. Require message types implement Debug

    This enables useful output in the case of unhandled messages.
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    c98d1ab View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    3ce9b22 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    5427d1f View commit details
    Browse the repository at this point in the history
  23. Fix widget derive

    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    76143be View commit details
    Browse the repository at this point in the history
  24. DragHandle: return the raw offset without updating

    Slider now holds handle to its detents.
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    320d46c View commit details
    Browse the repository at this point in the history
  25. Add kas::event::MsgPressFocus

    Slider now takes nav-focus on click.
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    24fdb92 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    d109a38 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    5457e21 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    975a410 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    423d77c View commit details
    Browse the repository at this point in the history
  30. Rename Handler::on_message → handle_message

    Same for SingleData, ListData, MatrixData
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    37cec51 View commit details
    Browse the repository at this point in the history
  31. Add List::on_message, Grid::on_message; remove IndexMsg

    This avoids unwanted sending of IndexMsg and is more flexible.
    Fixes light/dark theme buttons in the gallery (embedded in a Row).
    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    773fad2 View commit details
    Browse the repository at this point in the history
  32. Gallery: fix "Edit" button

    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    16a8ca4 View commit details
    Browse the repository at this point in the history
  33. Remove Driver::get (unused)

    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    f885fff View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    1fb1158 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    29d0029 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    eab5f3b View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    9c97461 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    c6156ef View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    3f995ee View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    80d99e1 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    92a3185 View commit details
    Browse the repository at this point in the history
  42. Clippy fixes

    dhardy committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    d22e412 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Fix doc links

    dhardy committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    81116e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec2cb54 View commit details
    Browse the repository at this point in the history
  3. Fix test: combobox

    dhardy committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    f0d77e8 View commit details
    Browse the repository at this point in the history
  4. Bump MSRV to 1.58

    dhardy committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    f921dd2 View commit details
    Browse the repository at this point in the history
  5. Fix examples/mandlebrot

    dhardy committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    149e34f View commit details
    Browse the repository at this point in the history