-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less type safety: remove Handler::Msg assoc. type #309
Commits on Apr 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f2bc440 - Browse repository at this point
Copy the full SHA f2bc440View commit details -
Remove "Received by ..." message route tracing
This is impossible with the new message model. No big loss.
Configuration menu - View commit details
-
Copy full SHA for ae6a8e4 - Browse repository at this point
Copy the full SHA ae6a8e4View commit details -
ComboBox, SubMenu: do not handle Response::Select
This is not emitted by their children
Configuration menu - View commit details
-
Copy full SHA for c7a6ca0 - Browse repository at this point
Copy the full SHA c7a6ca0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b315f8 - Browse repository at this point
Copy the full SHA 1b315f8View commit details -
This breaks ComboBox and automatic updating of data through view widgets (to be fixed later).
Configuration menu - View commit details
-
Copy full SHA for 9cc2861 - Browse repository at this point
Copy the full SHA 9cc2861View commit details -
Remove Handler::Msg type parameter
This is a big revision to event handling, allowing multiple simultaneous messages from children and removing the need to parametrize many widgets over the message type. Incomplete: new Handler::on_message method not called yet. Remove Response::Msg, VoidMsg, #[derive(VoidMsg)] Replace event::ChildMsg with IndexMsg, SelectMsg Remove Updatable trait; add SingleData::on_message, etc. Remove #[widget(flatmap_msg=.., map_msg=.., use_msg=.., discard_msg)] make_widget!: remove -> message-type bound AdaptWidget: remove map_void_msg, map_msg_discard; adjust map_msg Button, etc...: event closure no longer returns Option<M> Grid, List: now push IndexMsg given a child message
Configuration menu - View commit details
-
Copy full SHA for 08768da - Browse repository at this point
Copy the full SHA 08768daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4713928 - Browse repository at this point
Copy the full SHA 4713928View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15f7956 - Browse repository at this point
Copy the full SHA 15f7956View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bdaabc - Browse repository at this point
Copy the full SHA 1bdaabcView commit details -
Replace Response::Select with SelectMsg
Rename widgets::view::SelectMsg → SelectionMsg
Configuration menu - View commit details
-
Copy full SHA for 4a025e3 - Browse repository at this point
Copy the full SHA 4a025e3View commit details -
Replace Response::Scrolled, Pan, Focus
New Scroll enum, EventMgr::set_scroll and Handler::scroll methods
Configuration menu - View commit details
-
Copy full SHA for e81bdbb - Browse repository at this point
Copy the full SHA e81bdbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d16fca - Browse repository at this point
Copy the full SHA 8d16fcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca1f392 - Browse repository at this point
Copy the full SHA ca1f392View commit details -
Remove SendEvent trait; new EventMgr::send method
This gets lots of things working again, but many bugs remain.
Configuration menu - View commit details
-
Copy full SHA for 1e25789 - Browse repository at this point
Copy the full SHA 1e25789View commit details -
ComboBox: push accelerator keys to a new layer
This prevents keys activating by combobox menu items from doing anything unless the menu is already open, which is the same behaviour as used by menus.
Configuration menu - View commit details
-
Copy full SHA for f66b3b0 - Browse repository at this point
Copy the full SHA f66b3b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c726445 - Browse repository at this point
Copy the full SHA c726445View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7eebc8 - Browse repository at this point
Copy the full SHA e7eebc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d57ed01 - Browse repository at this point
Copy the full SHA d57ed01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c230ad - Browse repository at this point
Copy the full SHA 8c230adView commit details -
Require message types implement Debug
This enables useful output in the case of unhandled messages.
Configuration menu - View commit details
-
Copy full SHA for c98d1ab - Browse repository at this point
Copy the full SHA c98d1abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ce9b22 - Browse repository at this point
Copy the full SHA 3ce9b22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5427d1f - Browse repository at this point
Copy the full SHA 5427d1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76143be - Browse repository at this point
Copy the full SHA 76143beView commit details -
DragHandle: return the raw offset without updating
Slider now holds handle to its detents.
Configuration menu - View commit details
-
Copy full SHA for 320d46c - Browse repository at this point
Copy the full SHA 320d46cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24fdb92 - Browse repository at this point
Copy the full SHA 24fdb92View commit details -
Configuration menu - View commit details
-
Copy full SHA for d109a38 - Browse repository at this point
Copy the full SHA d109a38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5457e21 - Browse repository at this point
Copy the full SHA 5457e21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 975a410 - Browse repository at this point
Copy the full SHA 975a410View commit details -
Configuration menu - View commit details
-
Copy full SHA for 423d77c - Browse repository at this point
Copy the full SHA 423d77cView commit details -
Rename Handler::on_message → handle_message
Same for SingleData, ListData, MatrixData
Configuration menu - View commit details
-
Copy full SHA for 37cec51 - Browse repository at this point
Copy the full SHA 37cec51View commit details -
Add List::on_message, Grid::on_message; remove IndexMsg
This avoids unwanted sending of IndexMsg and is more flexible. Fixes light/dark theme buttons in the gallery (embedded in a Row).
Configuration menu - View commit details
-
Copy full SHA for 773fad2 - Browse repository at this point
Copy the full SHA 773fad2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16a8ca4 - Browse repository at this point
Copy the full SHA 16a8ca4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f885fff - Browse repository at this point
Copy the full SHA f885fffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fb1158 - Browse repository at this point
Copy the full SHA 1fb1158View commit details -
*Data::update, handle_message: trigger update directly instead of ret…
…urning UpdateHandle
Configuration menu - View commit details
-
Copy full SHA for 29d0029 - Browse repository at this point
Copy the full SHA 29d0029View commit details -
Configuration menu - View commit details
-
Copy full SHA for eab5f3b - Browse repository at this point
Copy the full SHA eab5f3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c97461 - Browse repository at this point
Copy the full SHA 9c97461View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6156ef - Browse repository at this point
Copy the full SHA c6156efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f995ee - Browse repository at this point
Copy the full SHA 3f995eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80d99e1 - Browse repository at this point
Copy the full SHA 80d99e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92a3185 - Browse repository at this point
Copy the full SHA 92a3185View commit details -
Configuration menu - View commit details
-
Copy full SHA for d22e412 - Browse repository at this point
Copy the full SHA d22e412View commit details
Commits on Apr 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 81116e3 - Browse repository at this point
Copy the full SHA 81116e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec2cb54 - Browse repository at this point
Copy the full SHA ec2cb54View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0d77e8 - Browse repository at this point
Copy the full SHA f0d77e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f921dd2 - Browse repository at this point
Copy the full SHA f921dd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 149e34f - Browse repository at this point
Copy the full SHA 149e34fView commit details