Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: disabling cachew through CACHEW_DISABLE env #56

Merged
merged 7 commits into from
Sep 22, 2023

Conversation

seanbreckenridge
Copy link
Contributor

@seanbreckenridge seanbreckenridge commented Sep 21, 2023

went with fnmatch since I think that would be nicest to work with in $PATH environment variables, though feel free to suggest something else if you think it's better.

https://docs.python.org/3/library/fnmatch.html

@seanbreckenridge
Copy link
Contributor Author

If you think this is fine, will add some docs

src/cachew/__init__.py Outdated Show resolved Hide resolved
src/cachew/__init__.py Show resolved Hide resolved
src/cachew/__init__.py Show resolved Hide resolved
src/cachew/__init__.py Outdated Show resolved Hide resolved
@karlicoss
Copy link
Owner

hmm test_concurrent_writes[file] failed, but it's not cause of your changes -- I retried the CI. Thought I fixed that but apparently not =/

@karlicoss
Copy link
Owner

Thanks, looks neat! Up to you if you wanna add docs now, or we could give it a bit more testing first?

@seanbreckenridge
Copy link
Contributor Author

Added it into the doc/ folder now for, can move it into the ipynb file later yeah

@seanbreckenridge
Copy link
Contributor Author

seanbreckenridge commented Sep 22, 2023

alright should be good... I should really figure out some way to preview the .md files locally 😅

Edit: seanbreckenridge/dotfiles@d5c2d43

@karlicoss karlicoss merged commit f71a505 into karlicoss:master Sep 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants