-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
my.location.google_takeout fails to load from cache #54
Comments
Well, nevermind, just removing the file
Still strange that it couldnt recover though... I ran Wonder if I had some other code with the old cachew writing to the file while this was trying to create it or something... couldve been that Will leave this open for a bit incase I see the error again (and just good to have it up here), but will close if its not an issue |
Oh -- nevermind again, still an issue; should have checked on warm cache:
|
Ah, looks like this is because of a mismatch between int != float
I was using an def test(x: float) -> float:
return x * 2
test(4) # with int, not float Feels like something some could get bit on very easily, not sure if you want to add a special case |
Hmm yeah, I guess it makes sense to allow implicit conversions as long as the underlying serializer (i.e. json in this case) can handle it consistently. I guess it would also break if something passes So I think it's
Can you think of anything else? |
No, I think thats it Was just checking my autotui code since Ive written similar code like this before, only other think I check for is "true"/"false" and convert it to a bool, but thats more because its user-edited, shouldn't happen with cachew |
Oh, I was still running into the issue and thought there was some other issue but it looks like the latest commit isnt on pypi It works if I install from git Could you do a release so latest commit is included and I can bump the required version on |
released! |
Not sure if you can reproduce and havent tried to make a minimal example yet, but I thought would at least report the error:
Calling
hpi doctor -S my.location.google_takeout
fails to load from cache?I tried clearing the entire cachew dir and just restarting from nothing but same issue
This is fine though:
The text was updated successfully, but these errors were encountered: